1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
|
/*
This file is part of the clazy static checker.
Copyright (C) 2015 Klarälvdalens Datakonsult AB, a KDAB Group company, info@kdab.com
Author: Sérgio Martins <sergio.martins@kdab.com>
Copyright (C) 2015 Sergio Martins <smartins@kde.org>
This library is free software; you can redistribute it and/or
modify it under the terms of the GNU Library General Public
License as published by the Free Software Foundation; either
version 2 of the License, or (at your option) any later version.
This library is distributed in the hope that it will be useful,
but WITHOUT ANY WARRANTY; without even the implied warranty of
MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
Library General Public License for more details.
You should have received a copy of the GNU Library General Public License
along with this library; see the file COPYING.LIB. If not, write to
the Free Software Foundation, Inc., 51 Franklin Street, Fifth Floor,
Boston, MA 02110-1301, USA.
*/
#include "inefficientqlistbase.h"
#include "Utils.h"
#include "TypeUtils.h"
#include "ContextUtils.h"
#include "HierarchyUtils.h"
#include "TemplateUtils.h"
#include "StmtBodyRange.h"
#include <clang/AST/Decl.h>
#include <clang/AST/DeclCXX.h>
#include <clang/AST/AST.h>
#include <clang/AST/DeclTemplate.h>
using namespace clang;
using namespace std;
InefficientQListBase::InefficientQListBase(const std::string &name, ClazyContext *context, int ignoreMode)
: CheckBase(name, context)
, m_ignoreMode(ignoreMode)
{
}
bool InefficientQListBase::shouldIgnoreVariable(VarDecl *varDecl) const
{
DeclContext *context = varDecl->getDeclContext();
FunctionDecl *fDecl = context ? dyn_cast<FunctionDecl>(context) : nullptr;
if ((m_ignoreMode & IgnoreNonLocalVariable) && !clazy::isValueDeclInFunctionContext(varDecl)) {
return true;
}
if ((m_ignoreMode & IgnoreInFunctionWithSameReturnType) && fDecl && fDecl->getReturnType().getCanonicalType() == varDecl->getType().getCanonicalType()) {
return true;
}
Stmt *body = fDecl ? fDecl->getBody() : nullptr;
if ((m_ignoreMode & IgnoreIsAssignedToInFunction) && Utils::isAssignedTo(body, varDecl)) {
return true;
}
if ((m_ignoreMode & IgnoreIsPassedToFunctions) && Utils::isPassedToFunction(StmtBodyRange(body), varDecl, /*by-ref=*/ false)) {
return true;
}
if ((m_ignoreMode & IgnoreIsInitializedByFunctionCall) && Utils::isInitializedExternally(varDecl)) {
return true;
}
return false;
}
void InefficientQListBase::VisitDecl(clang::Decl *decl)
{
VarDecl *varDecl = dyn_cast<VarDecl>(decl);
if (!varDecl)
return;
QualType type = varDecl->getType();
const Type *t = type.getTypePtrOrNull();
if (!t)
return;
CXXRecordDecl *recordDecl = t->getAsCXXRecordDecl();
if (!recordDecl || recordDecl->getName() != "QList")
return;
const std::vector<clang::QualType> types = clazy::getTemplateArgumentsTypes(recordDecl);
if (types.empty())
return;
QualType qt2 = types[0];
if (!qt2.getTypePtrOrNull() || qt2->isIncompleteType())
return;
const int size_of_ptr = TypeUtils::sizeOfPointer(&m_astContext, qt2); // in bits
const int size_of_T = m_astContext.getTypeSize(qt2);
if (size_of_T > size_of_ptr && !shouldIgnoreVariable(varDecl)) {
string s = string("Use QVector instead of QList for type with size " + to_string(size_of_T / 8) + " bytes");
emitWarning(getLocStart(decl), s.c_str());
}
}
|
