1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
|
/*
This file is part of the clazy static checker.
Copyright (C) 2017 Sergio Martins <smartins@kde.org>
This library is free software; you can redistribute it and/or
modify it under the terms of the GNU Library General Public
License as published by the Free Software Foundation; either
version 2 of the License, or (at your option) any later version.
This library is distributed in the hope that it will be useful,
but WITHOUT ANY WARRANTY; without even the implied warranty of
MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
Library General Public License for more details.
You should have received a copy of the GNU Library General Public License
along with this library; see the file COPYING.LIB. If not, write to
the Free Software Foundation, Inc., 51 Franklin Street, Fifth Floor,
Boston, MA 02110-1301, USA.
*/
#include "connect-by-name.h"
#include "ClazyContext.h"
#include "AccessSpecifierManager.h"
#include "clazy_stl.h"
#include <clang/AST/DeclCXX.h>
#include <clang/Basic/LLVM.h>
#include <llvm/Support/Casting.h>
#include <vector>
namespace clang {
class Decl;
} // namespace clang
using namespace clang;
using namespace std;
ConnectByName::ConnectByName(const std::string &name, ClazyContext *context)
: CheckBase(name, context)
{
context->enableAccessSpecifierManager();
}
void ConnectByName::VisitDecl(clang::Decl *decl)
{
auto record = dyn_cast<CXXRecordDecl>(decl);
if (!record)
return;
AccessSpecifierManager *accessSpecifierManager = m_context->accessSpecifierManager;
if (!accessSpecifierManager)
return;
for (auto method : record->methods()) {
std::string name = method->getNameAsString();
if (clazy::startsWith(name, "on_")) {
QtAccessSpecifierType qst = accessSpecifierManager->qtAccessSpecifierType(method);
if (qst == QtAccessSpecifier_Slot) {
auto tokens = clazy::splitString(name, '_');
if (tokens.size() == 3) {
emitWarning(method, "Slots named on_foo_bar are error prone");
}
}
}
}
}
|
