1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
|
/*
This file is part of the clazy static checker.
Copyright (C) 2017 Klarälvdalens Datakonsult AB, a KDAB Group company, info@kdab.com
Author: Sérgio Martins <sergio.martins@kdab.com>
This library is free software; you can redistribute it and/or
modify it under the terms of the GNU Library General Public
License as published by the Free Software Foundation; either
version 2 of the License, or (at your option) any later version.
This library is distributed in the hope that it will be useful,
but WITHOUT ANY WARRANTY; without even the implied warranty of
MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
Library General Public License for more details.
You should have received a copy of the GNU Library General Public License
along with this library; see the file COPYING.LIB. If not, write to
the Free Software Foundation, Inc., 51 Franklin Street, Fifth Floor,
Boston, MA 02110-1301, USA.
*/
#include "connect-not-normalized.h"
#include "ClazyContext.h"
#include "Utils.h"
#include "HierarchyUtils.h"
#include "NormalizedSignatureUtils.h"
#include "QtUtils.h"
#include "TypeUtils.h"
#include <clang/AST/AST.h>
using namespace clang;
using namespace std;
ConnectNotNormalized::ConnectNotNormalized(const std::string &name, ClazyContext *context)
: CheckBase(name, context, Option_CanIgnoreIncludes)
{
}
void ConnectNotNormalized::VisitStmt(clang::Stmt *stmt)
{
if (handleQ_ARG(dyn_cast<CXXConstructExpr>(stmt)))
return;
handleConnect(dyn_cast<CallExpr>(stmt));
}
bool ConnectNotNormalized::handleQ_ARG(CXXConstructExpr *expr)
{
if (!expr || expr->getNumArgs() != 2)
return false;
CXXConstructorDecl *ctor = expr->getConstructor();
if (!ctor)
return false;
auto name = ctor->getNameAsString();
if (name != "QArgument" && name != "QReturnArgument")
return false;
StringLiteral *sl = clazy::getFirstChildOfType2<StringLiteral>(expr->getArg(0));
if (!sl)
return false;
const std::string original = sl->getString().str();
const std::string normalized = clazy::normalizedType(original.c_str());
if (original == normalized)
return false;
emitWarning(expr, "Signature is not normalized. Use " + normalized + " instead of " + original);
return true;
}
bool ConnectNotNormalized::handleConnect(CallExpr *callExpr)
{
if (!callExpr)
return false;
FunctionDecl *func = callExpr->getDirectCallee();
if (!func || func->getNumParams() != 1 || clazy::name(func) != "qFlagLocation")
return false;
{
// Only warn in connect statements, not disconnect, since there there's no optimization in Qt's side
auto parentCallExpr = clazy::getFirstParentOfType<CallExpr>(m_context->parentMap,
m_context->parentMap->getParent(callExpr), -1);
if (!parentCallExpr)
return false;
FunctionDecl *parentFunc = parentCallExpr->getDirectCallee();
if (!parentFunc || clazy::name(parentFunc) != "connect")
return false;
}
Expr *arg1 = callExpr->getArg(0);
StringLiteral *sl = clazy::getFirstChildOfType2<StringLiteral>(arg1);
if (!sl)
return false;
std::string original = sl->getString().str();
std::string normalized = clazy::normalizedSignature(original.c_str());
// discard the junk after '\0'
normalized = string(normalized.c_str());
original = string(original.c_str());
if (original == normalized)
return false;
// Remove first digit
normalized.erase(0, 1);
original.erase(0, 1);
emitWarning(getLocStart(callExpr), "Signature is not normalized. Use " + normalized + " instead of " + original);
return true;
}
|
