1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
|
/*
This file is part of the clazy static checker.
Copyright (C) 2016 Sergio Martins <smartins@kde.org>
This library is free software; you can redistribute it and/or
modify it under the terms of the GNU Library General Public
License as published by the Free Software Foundation; either
version 2 of the License, or (at your option) any later version.
This library is distributed in the hope that it will be useful,
but WITHOUT ANY WARRANTY; without even the implied warranty of
MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
Library General Public License for more details.
You should have received a copy of the GNU Library General Public License
along with this library; see the file COPYING.LIB. If not, write to
the Free Software Foundation, Inc., 51 Franklin Street, Fifth Floor,
Boston, MA 02110-1301, USA.
*/
#include "container-anti-pattern.h"
#include "Utils.h"
#include "StringUtils.h"
#include "MacroUtils.h"
#include "LoopUtils.h"
#include "HierarchyUtils.h"
#include <clang/AST/AST.h>
#include <clang/Lex/Lexer.h>
using namespace clang;
using namespace std;
ContainerAntiPattern::ContainerAntiPattern(const std::string &name, ClazyContext *context)
: CheckBase(name, context, Option_CanIgnoreIncludes)
{
}
static bool isInterestingCall(CallExpr *call)
{
FunctionDecl *func = call ? call->getDirectCallee() : nullptr;
if (!func)
return false;
static const vector<string> methods = { "QVector::toList", "QList::toVector", "QMap::values",
"QMap::keys", "QSet::toList", "QSet::values",
"QHash::values", "QHash::keys" };
return clazy::contains(methods, clazy::qualifiedMethodName(func));
}
void ContainerAntiPattern::VisitStmt(clang::Stmt *stmt)
{
if (handleLoop(stmt)) // catch for (auto i : map.values()) and such
return;
if (VisitQSet(stmt))
return;
vector<CallExpr *> calls = Utils::callListForChain(dyn_cast<CallExpr>(stmt));
if (calls.size() < 2)
return;
// For an expression like set.toList().count()...
CallExpr *callexpr1 = calls[calls.size() - 1]; // ...this would be toList()
// CallExpr *callexpr2 = calls[calls.size() - 2]; // ...and this would be count()
if (!isInterestingCall(callexpr1))
return;
emitWarning(getLocStart(stmt), "allocating an unneeded temporary container");
}
bool ContainerAntiPattern::VisitQSet(Stmt *stmt)
{
CXXMemberCallExpr *secondCall = dyn_cast<CXXMemberCallExpr>(stmt);
if (!secondCall || !secondCall->getMethodDecl())
return false;
CXXMethodDecl *secondMethod = secondCall->getMethodDecl();
const string secondMethodName = clazy::qualifiedMethodName(secondMethod);
if (secondMethodName != "QSet::isEmpty")
return false;
vector<CallExpr*> chainedCalls = Utils::callListForChain(secondCall);
if (chainedCalls.size() < 2)
return false;
CallExpr *firstCall = chainedCalls[chainedCalls.size() - 1];
FunctionDecl *firstFunc = firstCall->getDirectCallee();
if (!firstFunc)
return false;
CXXMethodDecl *firstMethod = dyn_cast<CXXMethodDecl>(firstFunc);
if (!firstMethod || clazy::qualifiedMethodName(firstMethod) != "QSet::intersect")
return false;
emitWarning(getLocStart(stmt), "Use QSet::intersects() instead");
return true;
}
bool ContainerAntiPattern::handleLoop(Stmt *stm)
{
Expr *containerExpr = clazy::containerExprForLoop(stm);
if (!containerExpr)
return false;
auto memberExpr = clazy::getFirstChildOfType2<CXXMemberCallExpr>(containerExpr);
if (isInterestingCall(memberExpr)) {
emitWarning(getLocStart(stm), "allocating an unneeded temporary container");
return true;
}
return false;
}
|
