1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
|
/*
This file is part of the clazy static checker.
Copyright (C) 2018 Sergio Martins <smartins@kde.org>
This library is free software; you can redistribute it and/or
modify it under the terms of the GNU Library General Public
License as published by the Free Software Foundation; either
version 2 of the License, or (at your option) any later version.
This library is distributed in the hope that it will be useful,
but WITHOUT ANY WARRANTY; without even the implied warranty of
MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
Library General Public License for more details.
You should have received a copy of the GNU Library General Public License
along with this library; see the file COPYING.LIB. If not, write to
the Free Software Foundation, Inc., 51 Franklin Street, Fifth Floor,
Boston, MA 02110-1301, USA.
*/
#include "fully-qualified-moc-types.h"
#include "Utils.h"
#include "HierarchyUtils.h"
#include "QtUtils.h"
#include "TypeUtils.h"
#include "ClazyContext.h"
#include "AccessSpecifierManager.h"
#include <clang/AST/AST.h>
using namespace clang;
using namespace std;
FullyQualifiedMocTypes::FullyQualifiedMocTypes(const std::string &name, ClazyContext *context)
: CheckBase(name, context)
{
context->enableAccessSpecifierManager();
enablePreProcessorCallbacks();
}
void FullyQualifiedMocTypes::VisitDecl(clang::Decl *decl)
{
auto method = dyn_cast<CXXMethodDecl>(decl);
if (!method)
return;
AccessSpecifierManager *accessSpecifierManager = m_context->accessSpecifierManager;
if (!accessSpecifierManager)
return;
if (handleQ_PROPERTY(method))
return;
if (method->isThisDeclarationADefinition() && !method->hasInlineBody())
return;
QtAccessSpecifierType qst = accessSpecifierManager->qtAccessSpecifierType(method);
if (qst != QtAccessSpecifier_Signal && qst != QtAccessSpecifier_Slot && qst != QtAccessSpecifier_Invokable)
return;
for (auto param : method->parameters()) {
QualType t = TypeUtils::pointeeQualType(param->getType());
if (!t.isNull()) {
std::string typeName = clazy::name(t, lo(), /*asWritten=*/ true);
if (typeName == "QPrivateSignal")
continue;
std::string qualifiedTypeName = clazy::name(t, lo(), /*asWritten=*/ false);
if (typeName != qualifiedTypeName) {
emitWarning(method, string(accessSpecifierManager->qtAccessSpecifierTypeStr(qst)) + " arguments need to be fully-qualified (" + qualifiedTypeName + " instead of " + typeName + ")");
}
}
}
}
bool FullyQualifiedMocTypes::isGadget(CXXRecordDecl *record) const
{
SourceLocation startLoc = getLocStart(record);
for (const SourceLocation &loc : m_qgadgetMacroLocations) {
if (sm().getFileID(loc) != sm().getFileID(startLoc))
continue; // Different file
if (sm().isBeforeInSLocAddrSpace(startLoc, loc) && sm().isBeforeInSLocAddrSpace(loc, getLocEnd(record)))
return true; // We found a Q_GADGET after start and before end, it's ours.
}
return false;
}
bool FullyQualifiedMocTypes::handleQ_PROPERTY(CXXMethodDecl *method)
{
if (clazy::name(method) != "qt_static_metacall" || !method->hasBody() || method->getDefinition() != method)
return false;
/**
* Basically diffed a .moc file with and without a namespaced property,
* the difference is one reinterpret_cast, under an if (_c == QMetaObject::ReadProperty), so
* that's what we cheak.
*
* The AST doesn't have the Q_PROPERTIES as they expand to nothing, so we have
* to do it this way.
*/
auto ifs = clazy::getStatements<IfStmt>(method->getBody());
for (auto iff : ifs) {
auto bo = dyn_cast<BinaryOperator>(iff->getCond());
if (!bo)
continue;
auto enumRefs = clazy::getStatements<DeclRefExpr>(bo->getRHS());
if (enumRefs.size() == 1) {
auto enumerator = dyn_cast<EnumConstantDecl>(enumRefs.at(0)->getDecl());
if (enumerator && enumerator->getName() == "ReadProperty") {
auto reinterprets = clazy::getStatements<CXXReinterpretCastExpr>(iff);
for (auto reinterpret : reinterprets) {
QualType qt = TypeUtils::pointeeQualType(reinterpret->getTypeAsWritten());
auto record = qt->getAsCXXRecordDecl();
if (!record || !isGadget(record))
continue;
string nameAsWritten = clazy::name(qt, lo(), /*asWritten=*/ true);
string fullyQualifiedName = clazy::name(qt, lo(), /*asWritten=*/ false);
if (nameAsWritten != fullyQualifiedName) {
// warn in the cxxrecorddecl, since we don't want to warn in the .moc files.
// Ideally we would do some cross checking with the Q_PROPERTIES, but that's not in the AST
emitWarning(getLocStart(method->getParent()), "Q_PROPERTY of type " + nameAsWritten + " should use full qualification (" + fullyQualifiedName + ")");
}
}
return true;
}
}
}
return true; // true, so processing doesn't continue, it's a qt_static_metacall, nothing interesting here unless the properties above
}
void FullyQualifiedMocTypes::VisitMacroExpands(const clang::Token &MacroNameTok,
const clang::SourceRange &range, const MacroInfo *)
{
IdentifierInfo *ii = MacroNameTok.getIdentifierInfo();
if (ii && ii->getName() == "Q_GADGET")
registerQ_GADGET(range.getBegin());
}
void FullyQualifiedMocTypes::registerQ_GADGET(SourceLocation loc)
{
m_qgadgetMacroLocations.push_back(loc);
}
|
