1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
|
/*
This file is part of the clazy static checker.
Copyright (C) 2016-2017 Sergio Martins <smartins@kde.org>
This library is free software; you can redistribute it and/or
modify it under the terms of the GNU Library General Public
License as published by the Free Software Foundation; either
version 2 of the License, or (at your option) any later version.
This library is distributed in the hope that it will be useful,
but WITHOUT ANY WARRANTY; without even the implied warranty of
MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
Library General Public License for more details.
You should have received a copy of the GNU Library General Public License
along with this library; see the file COPYING.LIB. If not, write to
the Free Software Foundation, Inc., 51 Franklin Street, Fifth Floor,
Boston, MA 02110-1301, USA.
*/
#include "lambda-in-connect.h"
#include "ClazyContext.h"
#include "Utils.h"
#include "StringUtils.h"
#include "HierarchyUtils.h"
#include "ContextUtils.h"
#include "QtUtils.h"
#include <clang/AST/AST.h>
#include <clang/Lex/Lexer.h>
using namespace clang;
using namespace std;
LambdaInConnect::LambdaInConnect(const std::string &name, ClazyContext *context)
: CheckBase(name, context, Option_CanIgnoreIncludes)
{
}
void LambdaInConnect::VisitStmt(clang::Stmt *stmt)
{
auto lambda = dyn_cast<LambdaExpr>(stmt);
if (!lambda)
return;
auto captures = lambda->captures();
if (captures.begin() == captures.end())
return;
auto callExpr = clazy::getFirstParentOfType<CallExpr>(m_context->parentMap, lambda);
if (clazy::qualifiedMethodName(callExpr) != "QObject::connect")
return;
ValueDecl *senderDecl = clazy::signalSenderForConnect(callExpr);
if (senderDecl) {
const Type *t = senderDecl->getType().getTypePtrOrNull();
if (t && !t->isPointerType())
return;
}
ValueDecl *receiverDecl = clazy::signalReceiverForConnect(callExpr);
for (auto capture : captures) {
if (capture.getCaptureKind() == clang::LCK_ByRef) {
VarDecl *declForCapture = capture.getCapturedVar();
if (declForCapture && declForCapture != receiverDecl && clazy::isValueDeclInFunctionContext(declForCapture))
emitWarning(capture.getLocation(), "captured local variable by reference might go out of scope before lambda is called");
}
}
}
|
