1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
|
/*
This file is part of the clazy static checker.
Copyright (C) 2017 Sergio Martins <smartins@kde.org>
This library is free software; you can redistribute it and/or
modify it under the terms of the GNU Library General Public
License as published by the Free Software Foundation; either
version 2 of the License, or (at your option) any later version.
This library is distributed in the hope that it will be useful,
but WITHOUT ANY WARRANTY; without even the implied warranty of
MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
Library General Public License for more details.
You should have received a copy of the GNU Library General Public License
along with this library; see the file COPYING.LIB. If not, write to
the Free Software Foundation, Inc., 51 Franklin Street, Fifth Floor,
Boston, MA 02110-1301, USA.
*/
#include "StringUtils.h"
#include "qcolor-from-literal.h"
#include "checkmanager.h"
using namespace clang;
using namespace clang::ast_matchers;
using namespace std;
// TODO: setNameFromString()
static bool handleStringLiteral(const StringLiteral *literal)
{
if (!literal)
return false;
int length = literal->getLength();
if (length != 4 && length != 7 && length != 9 && length != 13)
return false;
llvm::StringRef str = literal->getString();
if (!str.startswith("#"))
return false;
return true;
}
class QColorFromLiteral_Callback : public ClazyAstMatcherCallback
{
public :
QColorFromLiteral_Callback(CheckBase *base)
: ClazyAstMatcherCallback(base)
{
}
void run(const MatchFinder::MatchResult &result) override
{
const StringLiteral *lt = result.Nodes.getNodeAs<StringLiteral>("myLiteral");
if (handleStringLiteral(lt))
m_check->emitWarning(lt, "The QColor ctor taking ints is cheaper than the one taking string literals");
}
};
QColorFromLiteral::QColorFromLiteral(const std::string &name, ClazyContext *context)
: CheckBase(name, context)
, m_astMatcherCallBack(new QColorFromLiteral_Callback(this))
{
}
QColorFromLiteral::~QColorFromLiteral()
{
delete m_astMatcherCallBack;
}
void QColorFromLiteral::VisitStmt(Stmt *stmt)
{
auto call = dyn_cast<CXXMemberCallExpr>(stmt);
if (!call || call->getNumArgs() != 1)
return;
string name = StringUtils::qualifiedMethodName(call);
if (name != "QColor::setNamedColor")
return;
StringLiteral *lt = HierarchyUtils::getFirstChildOfType2<StringLiteral>(call->getArg(0));
if (handleStringLiteral(lt))
emitWarning(lt, "The ctor taking ints is cheaper than QColor::setNamedColor(QString)");
}
void QColorFromLiteral::registerASTMatchers(MatchFinder &finder)
{
finder.addMatcher(cxxConstructExpr(hasDeclaration(namedDecl(hasName("QColor"))),
hasArgument(0, stringLiteral().bind("myLiteral"))), m_astMatcherCallBack);
}
REGISTER_CHECK("qcolor-from-literal", QColorFromLiteral, CheckLevel0)
|
