1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
|
/*
This file is part of the clazy static checker.
Copyright (C) 2016 Sergio Martins <smartins@kde.org>
This library is free software; you can redistribute it and/or
modify it under the terms of the GNU Library General Public
License as published by the Free Software Foundation; either
version 2 of the License, or (at your option) any later version.
This library is distributed in the hope that it will be useful,
but WITHOUT ANY WARRANTY; without even the implied warranty of
MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
Library General Public License for more details.
You should have received a copy of the GNU Library General Public License
along with this library; see the file COPYING.LIB. If not, write to
the Free Software Foundation, Inc., 51 Franklin Street, Fifth Floor,
Boston, MA 02110-1301, USA.
*/
#include "qstring-insensitive-allocation.h"
#include "Utils.h"
#include "StringUtils.h"
#include <clang/AST/AST.h>
#include <clang/Lex/Lexer.h>
using namespace clang;
using namespace std;
QStringInsensitiveAllocation::QStringInsensitiveAllocation(const std::string &name, ClazyContext *context)
: CheckBase(name, context, Option_CanIgnoreIncludes)
{
}
static bool isInterestingCall1(CallExpr *call)
{
FunctionDecl *func = call->getDirectCallee();
if (!func)
return false;
static const vector<string> methods = { "QString::toUpper", "QString::toLower" };
return clazy::contains(methods, clazy::qualifiedMethodName(func));
}
static bool isInterestingCall2(CallExpr *call)
{
FunctionDecl *func = call->getDirectCallee();
if (!func)
return false;
static const vector<string> methods = { "QString::endsWith", "QString::startsWith",
"QString::contains", "QString::compare" };
return clazy::contains(methods, clazy::qualifiedMethodName(func));
}
void QStringInsensitiveAllocation::VisitStmt(clang::Stmt *stmt)
{
vector<CallExpr *> calls = Utils::callListForChain(dyn_cast<CallExpr>(stmt));
if (calls.size() < 2)
return;
CallExpr *call1 = calls[calls.size() - 1];
CallExpr *call2 = calls[calls.size() - 2];
if (!isInterestingCall1(call1) || !isInterestingCall2(call2))
return;
emitWarning(getLocStart(stmt), "unneeded allocation");
}
|
