1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
|
/*
This file is part of the clazy static checker.
Copyright (C) 2017 Sergio Martins <sergio.martins@kdab.com>
This library is free software; you can redistribute it and/or
modify it under the terms of the GNU Library General Public
License as published by the Free Software Foundation; either
version 2 of the License, or (at your option) any later version.
This library is distributed in the hope that it will be useful,
but WITHOUT ANY WARRANTY; without even the implied warranty of
MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
Library General Public License for more details.
You should have received a copy of the GNU Library General Public License
along with this library; see the file COPYING.LIB. If not, write to
the Free Software Foundation, Inc., 51 Franklin Street, Fifth Floor,
Boston, MA 02110-1301, USA.
*/
#include "connect-3arg-lambda.h"
#include "Utils.h"
#include "HierarchyUtils.h"
#include "QtUtils.h"
#include "TypeUtils.h"
#include <clang/AST/AST.h>
using namespace clang;
using namespace std;
Connect3ArgLambda::Connect3ArgLambda(const std::string &name, ClazyContext *context)
: CheckBase(name, context, Option_CanIgnoreIncludes)
{
}
void Connect3ArgLambda::VisitStmt(clang::Stmt *stmt)
{
auto callExpr = dyn_cast<CallExpr>(stmt);
if (!callExpr)
return;
FunctionDecl *fdecl = callExpr->getDirectCallee();
if (!fdecl)
return;
const uint numParams = fdecl->getNumParams();
if (numParams != 2 && numParams != 3)
return;
if (fdecl->getQualifiedNameAsString() == "QTimer::singleShot") {
processQTimer(fdecl, stmt);
return;
}
if (numParams != 3 || !clazy::isConnect(fdecl))
return;
auto lambda = clazy::getFirstChildOfType2<LambdaExpr>(callExpr->getArg(2));
if (!lambda)
return;
DeclRefExpr *senderDeclRef = nullptr;
MemberExpr *senderMemberExpr = nullptr;
Stmt *s = callExpr->getArg(0);
while (s) {
if ((senderDeclRef = dyn_cast<DeclRefExpr>(s)))
break;
if ((senderMemberExpr = dyn_cast<MemberExpr>(s)))
break;
s = clazy::getFirstChild(s);
}
// The sender can be: this
auto senderThis = clazy::unpeal<CXXThisExpr>(callExpr->getArg(0), clazy::IgnoreImplicitCasts);
// The variables used inside the lambda
auto declrefs = clazy::getStatements<DeclRefExpr>(lambda->getBody());
ValueDecl *senderDecl = senderDeclRef ? senderDeclRef->getDecl() : nullptr;
// We'll only warn if the lambda is dereferencing another QObject (besides the sender)
bool found = false;
for (auto declref : declrefs) {
ValueDecl *decl = declref->getDecl();
if (decl == senderDecl)
continue; // It's the sender, continue.
if (clazy::isQObject(decl->getType())) {
found = true;
break;
}
}
if (!found) {
auto thisexprs = clazy::getStatements<CXXThisExpr>(lambda->getBody());
if (!thisexprs.empty() && !senderThis)
found = true;
}
if (found)
emitWarning(stmt, "Pass a context object as 3rd connect parameter");
}
void Connect3ArgLambda::processQTimer(FunctionDecl *func, Stmt *stmt)
{
// Signatures to catch:
// QTimer::singleShot(int msec, Functor functor)
// QTimer::singleShot(int msec, Qt::TimerType timerType, Functor functor)
const uint numParams = func->getNumParams();
if (numParams == 2) {
if (func->getParamDecl(0)->getNameAsString() == "interval" &&
func->getParamDecl(1)->getNameAsString() == "slot") {
emitWarning(stmt, "Pass a context object as 2nd singleShot parameter");
}
} else if (numParams == 3) {
if (func->getParamDecl(0)->getNameAsString() == "interval" &&
func->getParamDecl(1)->getNameAsString() == "timerType" &&
func->getParamDecl(2)->getNameAsString() == "slot") {
emitWarning(stmt, "Pass a context object as 3nd singleShot parameter");
}
}
}
|
