1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
|
/*
This file is part of the clazy static checker.
Copyright (C) 2017 Sergio Martins <smartins@kde.org>
This library is free software; you can redistribute it and/or
modify it under the terms of the GNU Library General Public
License as published by the Free Software Foundation; either
version 2 of the License, or (at your option) any later version.
This library is distributed in the hope that it will be useful,
but WITHOUT ANY WARRANTY; without even the implied warranty of
MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
Library General Public License for more details.
You should have received a copy of the GNU Library General Public License
along with this library; see the file COPYING.LIB. If not, write to
the Free Software Foundation, Inc., 51 Franklin Street, Fifth Floor,
Boston, MA 02110-1301, USA.
*/
#include "const-signal-or-slot.h"
#include "Utils.h"
#include "HierarchyUtils.h"
#include "QtUtils.h"
#include "TypeUtils.h"
#include "checkmanager.h"
#include "ClazyContext.h"
#include "AccessSpecifierManager.h"
#include <clang/AST/AST.h>
using namespace clang;
using namespace std;
ConstSignalOrSlot::ConstSignalOrSlot(const std::string &name, ClazyContext *context)
: CheckBase(name, context)
{
context->enableAccessSpecifierManager();
}
void ConstSignalOrSlot::VisitStmt(clang::Stmt *stmt)
{
auto call = dyn_cast<CallExpr>(stmt);
AccessSpecifierManager *accessSpecifierManager = m_context->accessSpecifierManager;
if (!call || !accessSpecifierManager)
return;
FunctionDecl *func = call->getDirectCallee();
if (!QtUtils::isConnect(func) || !QtUtils::connectHasPMFStyle(func))
return;
CXXMethodDecl *slot = QtUtils::receiverMethodForConnect(call);
if (!slot || !slot->isConst() || slot->getReturnType()->isVoidType()) // const and returning void must do something, so not a getter
return;
QtAccessSpecifierType specifierType = accessSpecifierManager->qtAccessSpecifierType(slot);
if (specifierType == QtAccessSpecifier_Slot || specifierType == QtAccessSpecifier_Signal)
return; // For stuff explicitly marked as slots or signals we use VisitDecl
// Here the user is connecting to a const method, which isn't marked as slot or signal and returns non-void
// Looks like a getter!
emitWarning(stmt, slot->getQualifiedNameAsString() + " is not a slot, and is possibly a getter");
}
void ConstSignalOrSlot::VisitDecl(Decl *decl)
{
auto method = dyn_cast<CXXMethodDecl>(decl);
if (!method || !method->isConst())
return;
AccessSpecifierManager *a = m_context->accessSpecifierManager;
if (!a)
return;
if (method->isThisDeclarationADefinition() && !method->hasInlineBody()) // Don't warn twice
return;
CXXRecordDecl *record = method->getParent();
if (TypeUtils::derivesFrom(record, "QDBusAbstractInterface"))
return;
QtAccessSpecifierType specifierType = a->qtAccessSpecifierType(method);
if (specifierType == QtAccessSpecifier_Slot && !method->getReturnType()->isVoidType()) {
emitWarning(decl, "getter " + method->getQualifiedNameAsString() + " possibly mismarked as a slot");
} else if (specifierType == QtAccessSpecifier_Signal) {
emitWarning(decl, "signal " + method->getQualifiedNameAsString() + " shouldn't be const");
}
}
REGISTER_CHECK("const-signal-or-slot", ConstSignalOrSlot, CheckLevel1)
|
