1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
|
/*
This file is part of the clazy static checker.
Copyright (C) 2017 Sergio Martins <smartins@kde.org>
This library is free software; you can redistribute it and/or
modify it under the terms of the GNU Library General Public
License as published by the Free Software Foundation; either
version 2 of the License, or (at your option) any later version.
This library is distributed in the hope that it will be useful,
but WITHOUT ANY WARRANTY; without even the implied warranty of
MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
Library General Public License for more details.
You should have received a copy of the GNU Library General Public License
along with this library; see the file COPYING.LIB. If not, write to
the Free Software Foundation, Inc., 51 Franklin Street, Fifth Floor,
Boston, MA 02110-1301, USA.
*/
#include "install-event-filter.h"
#include "Utils.h"
#include "HierarchyUtils.h"
#include "QtUtils.h"
#include "TypeUtils.h"
#include <clang/AST/AST.h>
using namespace clang;
using namespace std;
InstallEventFilter::InstallEventFilter(const std::string &name, ClazyContext *context)
: CheckBase(name, context, Option_CanIgnoreIncludes)
{
}
void InstallEventFilter::VisitStmt(clang::Stmt *stmt)
{
auto memberCallExpr = dyn_cast<CXXMemberCallExpr>(stmt);
if (!memberCallExpr || memberCallExpr->getNumArgs() != 1)
return;
FunctionDecl *func = memberCallExpr->getDirectCallee();
if (!func || func->getQualifiedNameAsString() != "QObject::installEventFilter")
return;
Expr *expr = memberCallExpr->getImplicitObjectArgument();
if (!expr)
return;
if (!isa<CXXThisExpr>(clazy::getFirstChildAtDepth(expr, 1)))
return;
Expr *arg1 = memberCallExpr->getArg(0);
arg1 = arg1 ? arg1->IgnoreCasts() : nullptr;
CXXRecordDecl *record = TypeUtils::typeAsRecord(arg1);
auto methods = Utils::methodsFromString(record, "eventFilter");
for (auto method : methods) {
if (method->getQualifiedNameAsString() != "QObject::eventFilter") // It overrides it, probably on purpose then, don't warn.
return;
}
emitWarning(stmt, "'this' should usually be the filter object, not the monitored one.");
}
|
