1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
|
/*
This file is part of the clazy static checker.
Copyright (C) 2015 Klarälvdalens Datakonsult AB, a KDAB Group company, info@kdab.com
Author: Sérgio Martins <sergio.martins@kdab.com>
Copyright (C) 2015 Sergio Martins <smartins@kde.org>
This library is free software; you can redistribute it and/or
modify it under the terms of the GNU Library General Public
License as published by the Free Software Foundation; either
version 2 of the License, or (at your option) any later version.
This library is distributed in the hope that it will be useful,
but WITHOUT ANY WARRANTY; without even the implied warranty of
MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
Library General Public License for more details.
You should have received a copy of the GNU Library General Public License
along with this library; see the file COPYING.LIB. If not, write to
the Free Software Foundation, Inc., 51 Franklin Street, Fifth Floor,
Boston, MA 02110-1301, USA.
*/
#include "nonpodstatic.h"
#include "Utils.h"
#include "StringUtils.h"
#include "MacroUtils.h"
#include "QtUtils.h"
#include "checkmanager.h"
#include "ClazyContext.h"
#include <clang/AST/DeclCXX.h>
#include <clang/Lex/Lexer.h>
using namespace clang;
using namespace std;
static bool shouldIgnoreType(const std::string &name)
{
// Q_GLOBAL_STATIC and such
static vector<string> blacklist = {"Holder", "AFUNC", "QLoggingCategory", "QThreadStorage"};
return clazy_std::contains(blacklist, name);
}
NonPodStatic::NonPodStatic(const std::string &name, ClazyContext *context)
: CheckBase(name, context)
{
m_filesToIgnore = { "main.cpp", "qrc_", "qdbusxml2cpp" };
}
void NonPodStatic::VisitStmt(clang::Stmt *stm)
{
VarDecl *varDecl = m_lastDecl ? dyn_cast<VarDecl>(m_lastDecl) : nullptr;
if (!varDecl || varDecl->isConstexpr() || varDecl->isExternallyVisible() || !varDecl->isFileVarDecl())
return;
if (shouldIgnoreFile(stm->getLocStart()))
return;
StorageDuration sd = varDecl->getStorageDuration();
if (sd != StorageDuration::SD_Static)
return;
const SourceLocation declStart = varDecl->getLocStart();
auto macroName = Lexer::getImmediateMacroName(declStart, sm(), lo());
if (clazy_std::startsWithAny(macroName, { "Q_IMPORT_PLUGIN", "Q_CONSTRUCTOR_FUNCTION", "Q_DESTRUCTOR_FUNCTION"})) // Don't warn on these
return;
CXXConstructExpr *ctorExpr = dyn_cast<CXXConstructExpr>(stm);
if (!ctorExpr)
return;
auto ctorDecl = ctorExpr->getConstructor();
auto recordDecl = ctorDecl ? ctorDecl->getParent() : nullptr;
if (!recordDecl)
return;
if (recordDecl->hasTrivialDestructor()) {
// Has a trivial dtor, but now lets check the ctors.
if (ctorDecl->isDefaultConstructor() && recordDecl->hasTrivialDefaultConstructor()) {
// both dtor and called ctor are trivial, no warning
return;
} else if (ctorDecl->isConstexpr()) {
// Used ctor is constexpr, it's fine
return;
}
}
if (m_context->isQtDeveloper() && QtUtils::isBootstrapping(m_preprocessorOpts))
return;
const string className = recordDecl->getName();
if (!shouldIgnoreType(className)) {
std::string error = "non-POD static (" + className + ')';
emitWarning(declStart, error.c_str());
}
}
REGISTER_CHECK("non-pod-global-static", NonPodStatic, CheckLevel1)
|
