1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
|
/*
This file is part of the clazy static checker.
Copyright (C) 2017 Sergio Martins <smartins@kde.org>
This library is free software; you can redistribute it and/or
modify it under the terms of the GNU Library General Public
License as published by the Free Software Foundation; either
version 2 of the License, or (at your option) any later version.
This library is distributed in the hope that it will be useful,
but WITHOUT ANY WARRANTY; without even the implied warranty of
MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
Library General Public License for more details.
You should have received a copy of the GNU Library General Public License
along with this library; see the file COPYING.LIB. If not, write to
the Free Software Foundation, Inc., 51 Franklin Street, Fifth Floor,
Boston, MA 02110-1301, USA.
*/
#include "qhash-namespace.h"
#include "Utils.h"
#include "HierarchyUtils.h"
#include "QtUtils.h"
#include "TypeUtils.h"
#include "ContextUtils.h"
#include "StringUtils.h"
#include "ClazyContext.h"
#include "checkmanager.h"
#include "PreProcessorVisitor.h"
#include <clang/AST/AST.h>
using namespace clang;
using namespace std;
qhash_namespace::qhash_namespace(const std::string &name, ClazyContext *context)
: CheckBase(name, context)
{
if (context->isQtDeveloper())
context->enablePreprocessorVisitor();
}
void qhash_namespace::VisitDecl(clang::Decl *decl)
{
auto func = dyn_cast<FunctionDecl>(decl);
if (!func || isa<CXXMethodDecl>(func) || func->getNumParams() == 0 || func->getNameAsString() != "qHash")
return;
ParmVarDecl *firstArg = func->getParamDecl(0);
NamespaceDecl *argumentNS = ContextUtils::namespaceForType(firstArg->getType());
NamespaceDecl *qHashNS = ContextUtils::namespaceForFunction(func);
std::string msg;
if (qHashNS && argumentNS) {
const string argumentNSstr = argumentNS->getQualifiedNameAsString();
const string qhashNSstr = qHashNS->getQualifiedNameAsString();
if (argumentNSstr != qhashNSstr)
msg = "Move qHash(" + StringUtils::simpleTypeName(firstArg->getType(), lo()) + ") to " + argumentNSstr + " namespace for ADL lookup";
} else if (qHashNS && !argumentNS) {
msg = "Move qHash(" + StringUtils::simpleTypeName(firstArg->getType(), lo()) + ") out of namespace " + qHashNS->getQualifiedNameAsString();
} else if (!qHashNS && argumentNS) {
msg = "Move qHash(" + StringUtils::simpleTypeName(firstArg->getType(), lo()) + ") into " + argumentNS->getQualifiedNameAsString() + " namespace for ADL lookup";
}
if (!msg.empty())
emitWarning(decl, msg);
if (m_context->isQtDeveloper()) {
PreProcessorVisitor *preProcessorVisitor = m_context->preprocessorVisitor;
if (preProcessorVisitor && !preProcessorVisitor->isBetweenQtNamespaceMacros(func->getLocStart())) {
emitWarning(decl, "qHash(" + StringUtils::simpleTypeName(firstArg->getType(), lo()) + ") must be declared before QT_END_NAMESPACE");
}
}
}
REGISTER_CHECK("qhash-namespace", qhash_namespace, CheckLevel1)
|
