1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
|
/*
This file is part of the clazy static checker.
Copyright (C) 2017 Sergio Martins <smartins@kde.org>
This library is free software; you can redistribute it and/or
modify it under the terms of the GNU Library General Public
License as published by the Free Software Foundation; either
version 2 of the License, or (at your option) any later version.
This library is distributed in the hope that it will be useful,
but WITHOUT ANY WARRANTY; without even the implied warranty of
MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
Library General Public License for more details.
You should have received a copy of the GNU Library General Public License
along with this library; see the file COPYING.LIB. If not, write to
the Free Software Foundation, Inc., 51 Franklin Street, Fifth Floor,
Boston, MA 02110-1301, USA.
*/
#include "qproperty-without-notify.h"
#include "Utils.h"
#include "HierarchyUtils.h"
#include "QtUtils.h"
#include "TypeUtils.h"
#include "checkmanager.h"
#include <clang/AST/AST.h>
using namespace clang;
using namespace std;
QPropertyWithoutNotify::QPropertyWithoutNotify(const std::string &name, ClazyContext *context)
: CheckBase(name, context)
{
enablePreProcessorCallbacks();
}
void QPropertyWithoutNotify::VisitMacroExpands(const clang::Token &MacroNameTok, const clang::SourceRange &range)
{
IdentifierInfo *ii = MacroNameTok.getIdentifierInfo();
if (!ii)
return;
if (ii->getName() == "Q_GADGET") {
m_lastIsGadget = true;
return;
}
if (ii->getName() == "Q_OBJECT") {
m_lastIsGadget = false;
return;
}
if (m_lastIsGadget || ii->getName() != "Q_PROPERTY")
return;
if (sm().isInSystemHeader(range.getBegin()))
return;
CharSourceRange crange = Lexer::getAsCharRange(range, sm(), lo());
string text = Lexer::getSourceText(crange, sm(), lo());
vector<string> split = clazy_std::splitString(text, ' ');
bool found_read = false;
bool found_constant = false;
bool found_notify = false;
for (const std::string &token : split) {
if (!found_read && token == "READ") {
found_read = true;
continue;
}
if (!found_constant && token == "CONSTANT") {
found_constant = true;
continue;
}
if (!found_notify && token == "NOTIFY") {
found_notify = true;
continue;
}
}
if (!found_read || (found_notify || found_constant))
return;
emitWarning(range.getBegin(), "Q_PROPERTY should have either NOTIFY or CONSTANT");
}
REGISTER_CHECK("qproperty-without-notify", QPropertyWithoutNotify, CheckLevel1)
|
