1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
|
/*
This file is part of the clazy static checker.
Copyright (C) 2016 Sergio Martins <smartins@kde.org>
This library is free software; you can redistribute it and/or
modify it under the terms of the GNU Library General Public
License as published by the Free Software Foundation; either
version 2 of the License, or (at your option) any later version.
This library is distributed in the hope that it will be useful,
but WITHOUT ANY WARRANTY; without even the implied warranty of
MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
Library General Public License for more details.
You should have received a copy of the GNU Library General Public License
along with this library; see the file COPYING.LIB. If not, write to
the Free Software Foundation, Inc., 51 Franklin Street, Fifth Floor,
Boston, MA 02110-1301, USA.
*/
#include "qstring-left.h"
#include "Utils.h"
#include "HierarchyUtils.h"
#include "QtUtils.h"
#include "TypeUtils.h"
#include "StringUtils.h"
#include <clang/AST/AST.h>
using namespace clang;
using namespace std;
QStringLeft::QStringLeft(const std::string &name, ClazyContext *context)
: CheckBase(name, context, Option_CanIgnoreIncludes)
{
}
void QStringLeft::VisitStmt(clang::Stmt *stmt)
{
auto memberCall = dyn_cast<CXXMemberCallExpr>(stmt);
if (!memberCall || clazy::qualifiedMethodName(memberCall) != "QString::left")
return;
if (memberCall->getNumArgs() == 0) // Doesn't happen
return;
Expr *firstArg = memberCall->getArg(0);
auto lt = firstArg ? dyn_cast<IntegerLiteral>(firstArg) : nullptr;
if (lt) {
const auto value = lt->getValue();
if (value == 0) {
emitWarning(stmt, "QString::left(0) returns an empty string");
} else if (value == 1){
emitWarning(stmt, "Use QString::at(0) instead of QString::left(1) to avoid temporary allocations (just be sure the string isn't empty).");
}
}
}
|
