1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
|
/*
This file is part of the clazy static checker.
Copyright (C) 2015 Klarälvdalens Datakonsult AB, a KDAB Group company, info@kdab.com
Author: Sérgio Martins <sergio.martins@kdab.com>
Copyright (C) 2015 Sergio Martins <smartins@kde.org>
This library is free software; you can redistribute it and/or
modify it under the terms of the GNU Library General Public
License as published by the Free Software Foundation; either
version 2 of the License, or (at your option) any later version.
This library is distributed in the hope that it will be useful,
but WITHOUT ANY WARRANTY; without even the implied warranty of
MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
Library General Public License for more details.
You should have received a copy of the GNU Library General Public License
along with this library; see the file COPYING.LIB. If not, write to
the Free Software Foundation, Inc., 51 Franklin Street, Fifth Floor,
Boston, MA 02110-1301, USA.
*/
#include "range-loop.h"
#include "Utils.h"
#include "QtUtils.h"
#include "TypeUtils.h"
#include "StringUtils.h"
#include "checkmanager.h"
#include "LoopUtils.h"
#include "StmtBodyRange.h"
#include <clang/AST/AST.h>
using namespace clang;
using namespace std;
RangeLoop::RangeLoop(const std::string &name, ClazyContext *context)
: CheckBase(name, context)
{
}
void RangeLoop::VisitStmt(clang::Stmt *stmt)
{
if (auto rangeLoop = dyn_cast<CXXForRangeStmt>(stmt)) {
processForRangeLoop(rangeLoop);
}
}
void RangeLoop::processForRangeLoop(CXXForRangeStmt *rangeLoop)
{
Expr *containerExpr = rangeLoop->getRangeInit();
if (!containerExpr)
return;
QualType qt = containerExpr->getType();
const Type *t = qt.getTypePtrOrNull();
if (!t || !t->isRecordType())
return;
checkPassByConstRefCorrectness(rangeLoop);
if (qt.isConstQualified()) // const won't detach
return;
auto loopVariableType = rangeLoop->getLoopVariable()->getType();
if (!TypeUtils::unrefQualType(loopVariableType).isConstQualified() && loopVariableType->isReferenceType())
return;
CXXRecordDecl *record = t->getAsCXXRecordDecl();
if (!QtUtils::isQtCOWIterableClass(Utils::rootBaseClass(record)))
return;
StmtBodyRange bodyRange(nullptr, &sm(), rangeLoop->getLocStart());
if (QtUtils::containerNeverDetaches(LoopUtils::containerDeclForLoop(rangeLoop), bodyRange))
return;
emitWarning(rangeLoop->getLocStart(), "c++11 range-loop might detach Qt container (" + record->getQualifiedNameAsString() + ')');
}
void RangeLoop::checkPassByConstRefCorrectness(CXXForRangeStmt *rangeLoop)
{
TypeUtils::QualTypeClassification classif;
auto varDecl = rangeLoop->getLoopVariable();
bool success = TypeUtils::classifyQualType(m_context, varDecl, /*by-ref*/classif, rangeLoop);
if (!success)
return;
if (classif.passNonTriviallyCopyableByConstRef) {
string error;
const string paramStr = StringUtils::simpleTypeName(varDecl->getType(), lo());
error = "Missing reference in range-for with non trivial type (" + paramStr + ')';
// We ignore classif.passSmallTrivialByValue because it doesn't matter, the compiler is able
// to optimize it, generating the same assembly, regardless of pass by value.
emitWarning(varDecl->getLocStart(), error.c_str());
}
}
REGISTER_CHECK("range-loop", RangeLoop, CheckLevel1)
|
