1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
|
/*
This file is part of the clazy static checker.
Copyright (C) 2017 Sergio Martins <smartins@kde.org>
This library is free software; you can redistribute it and/or
modify it under the terms of the GNU Library General Public
License as published by the Free Software Foundation; either
version 2 of the License, or (at your option) any later version.
This library is distributed in the hope that it will be useful,
but WITHOUT ANY WARRANTY; without even the implied warranty of
MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
Library General Public License for more details.
You should have received a copy of the GNU Library General Public License
along with this library; see the file COPYING.LIB. If not, write to
the Free Software Foundation, Inc., 51 Franklin Street, Fifth Floor,
Boston, MA 02110-1301, USA.
*/
#include "skipped-base-method.h"
#include "Utils.h"
#include "HierarchyUtils.h"
#include "QtUtils.h"
#include "TypeUtils.h"
#include "FunctionUtils.h"
#include <clang/AST/AST.h>
using namespace clang;
using namespace std;
SkippedBaseMethod::SkippedBaseMethod(const std::string &name, ClazyContext *context)
: CheckBase(name, context)
{
}
void SkippedBaseMethod::VisitStmt(clang::Stmt *stmt)
{
auto memberCall = dyn_cast<CXXMemberCallExpr>(stmt);
if (!memberCall)
return;
auto expr = memberCall->getImplicitObjectArgument();
auto thisExpr = clazy::unpeal<CXXThisExpr>(expr, clazy::IgnoreImplicitCasts);
if (!thisExpr)
return;
const CXXRecordDecl *thisClass = thisExpr->getType()->getPointeeCXXRecordDecl();
const CXXRecordDecl *baseClass = memberCall->getRecordDecl();
std::vector<CXXRecordDecl*> baseClasses;
if (!TypeUtils::derivesFrom(thisClass, baseClass, &baseClasses) || baseClasses.size() < 2)
return;
// We're calling a grand-base method, so check if a more direct base also implements it
for (int i = baseClasses.size() - 1; i > 0; --i) { // the higher indexes have the most derived classes
CXXRecordDecl *moreDirectBaseClass = baseClasses[i];
if (clazy::classImplementsMethod(moreDirectBaseClass, memberCall->getMethodDecl())) {
std::string msg = "Maybe you meant to call " + moreDirectBaseClass->getNameAsString() + "::" + memberCall->getMethodDecl()->getNameAsString() + "() instead";
emitWarning(stmt, msg);
}
}
}
|
