1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
|
/*
This file is part of the clazy static checker.
Copyright (C) 2016 Sergio Martins <smartins@kde.org>
This library is free software; you can redistribute it and/or
modify it under the terms of the GNU Library General Public
License as published by the Free Software Foundation; either
version 2 of the License, or (at your option) any later version.
This library is distributed in the hope that it will be useful,
but WITHOUT ANY WARRANTY; without even the implied warranty of
MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
Library General Public License for more details.
You should have received a copy of the GNU Library General Public License
along with this library; see the file COPYING.LIB. If not, write to
the Free Software Foundation, Inc., 51 Franklin Street, Fifth Floor,
Boston, MA 02110-1301, USA.
*/
#include "container-inside-loop.h"
#include "ClazyContext.h"
#include "Utils.h"
#include "checkmanager.h"
#include "StringUtils.h"
#include "LoopUtils.h"
#include "StmtBodyRange.h"
#include <clang/AST/ParentMap.h>
#include <clang/AST/AST.h>
#include <clang/Lex/Lexer.h>
using namespace clang;
using namespace std;
ContainerInsideLoop::ContainerInsideLoop(const std::string &name, ClazyContext *context)
: CheckBase(name, context)
{
}
void ContainerInsideLoop::VisitStmt(clang::Stmt *stmt)
{
auto *ctorExpr = dyn_cast<CXXConstructExpr>(stmt);
if (!ctorExpr)
return;
CXXConstructorDecl *ctor = ctorExpr->getConstructor();
if (!ctor || !clazy_std::equalsAny(StringUtils::classNameFor(ctor), { "QVector", "std::vector", "QList" }))
return;
DeclStmt *declStm = dyn_cast_or_null<DeclStmt>(m_context->parentMap->getParent(stmt));
if (!declStm || !declStm->isSingleDecl())
return;
Stmt *loopStmt = LoopUtils::isInLoop(m_context->parentMap, stmt);
if (!loopStmt)
return;
auto *varDecl = dyn_cast<VarDecl>(declStm->getSingleDecl());
if (!varDecl || Utils::isInitializedExternally(varDecl))
return;
if (Utils::isPassedToFunction(StmtBodyRange(loopStmt), varDecl, true))
return;
emitWarning(stmt->getLocStart(), "container inside loop causes unneeded allocations");
}
REGISTER_CHECK("container-inside-loop", ContainerInsideLoop, CheckLevel2)
|
