1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
|
/*
This file is part of the clazy static checker.
Copyright (C) 2015 Klarälvdalens Datakonsult AB, a KDAB Group company, info@kdab.com
Author: Sérgio Martins <sergio.martins@kdab.com>
Copyright (C) 2015-2016 Sergio Martins <smartins@kde.org>
This library is free software; you can redistribute it and/or
modify it under the terms of the GNU Library General Public
License as published by the Free Software Foundation; either
version 2 of the License, or (at your option) any later version.
This library is distributed in the hope that it will be useful,
but WITHOUT ANY WARRANTY; without even the implied warranty of
MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
Library General Public License for more details.
You should have received a copy of the GNU Library General Public License
along with this library; see the file COPYING.LIB. If not, write to
the Free Software Foundation, Inc., 51 Franklin Street, Fifth Floor,
Boston, MA 02110-1301, USA.
*/
#include "missing-typeinfo.h"
#include <clang/AST/DeclTemplate.h>
#include "TemplateUtils.h"
#include "QtUtils.h"
#include "StringUtils.h"
#include "SourceCompatibilityHelpers.h"
#include "clang/AST/DeclCXX.h"
#include "clang/AST/Type.h"
#include "clang/Basic/SourceManager.h"
#include "llvm/ADT/StringRef.h"
class ClazyContext;
namespace clang {
class Decl;
} // namespace clang
using namespace std;
using namespace clang;
MissingTypeInfo::MissingTypeInfo(const std::string &name, ClazyContext *context)
: CheckBase(name, context)
{
}
void MissingTypeInfo::VisitDecl(clang::Decl *decl)
{
ClassTemplateSpecializationDecl *tstdecl = clazy::templateDecl(decl);
if (!tstdecl)
return;
const bool isQList = tstdecl->getName() == "QList";
const bool isQVector = isQList ? false : tstdecl->getName() == "QVector";
if (!isQList && !isQVector) {
registerQTypeInfo(tstdecl);
return;
}
QualType qt2 = clazy::getTemplateArgumentType(tstdecl, 0);
const Type *t = qt2.getTypePtrOrNull();
CXXRecordDecl *record = t ? t->getAsCXXRecordDecl() : nullptr;
if (!record || !record->getDefinition() || typeHasClassification(qt2))
return; // Don't crash if we only have a fwd decl
const bool isCopyable = qt2.isTriviallyCopyableType(m_astContext);
const bool isTooBigForQList = isQList && clazy::isTooBigForQList(qt2, &m_astContext);
if ((isQVector || isTooBigForQList) && isCopyable) {
if (sm().isInSystemHeader(getLocStart(record)))
return;
std::string typeName = record->getName();
if (typeName == "QPair") // QPair doesn't use Q_DECLARE_TYPEINFO, but rather a explicit QTypeInfo.
return;
emitWarning(decl, "Missing Q_DECLARE_TYPEINFO: " + typeName);
emitWarning(record, "Type declared here:", false);
}
}
void MissingTypeInfo::registerQTypeInfo(ClassTemplateSpecializationDecl *decl)
{
if (decl->getName() == "QTypeInfo") {
const string typeName = clazy::getTemplateArgumentTypeStr(decl, 0, lo(), /**recordOnly=*/true);
if (!typeName.empty())
m_typeInfos.insert(typeName);
}
}
bool MissingTypeInfo::typeHasClassification(QualType qt) const
{
return m_typeInfos.find(clazy::simpleTypeName(qt, lo())) != m_typeInfos.end();
}
|
