1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
|
/*
This file is part of the clazy static checker.
Copyright (C) 2015 Klarälvdalens Datakonsult AB, a KDAB Group company, info@kdab.com
Author: Sérgio Martins <sergio.martins@kdab.com>
Copyright (C) 2015 Sergio Martins <smartins@kde.org>
This library is free software; you can redistribute it and/or
modify it under the terms of the GNU Library General Public
License as published by the Free Software Foundation; either
version 2 of the License, or (at your option) any later version.
This library is distributed in the hope that it will be useful,
but WITHOUT ANY WARRANTY; without even the implied warranty of
MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
Library General Public License for more details.
You should have received a copy of the GNU Library General Public License
along with this library; see the file COPYING.LIB. If not, write to
the Free Software Foundation, Inc., 51 Franklin Street, Fifth Floor,
Boston, MA 02110-1301, USA.
*/
#include "detachingmember.h"
#include "ClazyContext.h"
#include "checkmanager.h"
#include "Utils.h"
#include "HierarchyUtils.h"
#include "StringUtils.h"
#include <clang/AST/DeclCXX.h>
#include <clang/AST/Expr.h>
#include <clang/AST/ExprCXX.h>
using namespace clang;
using namespace std;
DetachingMember::DetachingMember(const std::string &name, ClazyContext *context)
: DetachingBase(name, context)
{
m_filesToIgnore = { "qstring.h" };
}
void DetachingMember::VisitStmt(clang::Stmt *stm)
{
CallExpr *callExpr = dyn_cast<CallExpr>(stm);
if (!callExpr)
return;
CXXMemberCallExpr *memberCall = dyn_cast<CXXMemberCallExpr>(callExpr);
CXXOperatorCallExpr *operatorExpr = dyn_cast<CXXOperatorCallExpr>(callExpr);
if (!memberCall && !operatorExpr)
return;
if (shouldIgnoreFile(stm->getLocStart()))
return;
CXXMethodDecl *method = nullptr;
ValueDecl *memberDecl = nullptr;
if (operatorExpr) {
FunctionDecl *func = operatorExpr->getDirectCallee();
method = func ? dyn_cast<CXXMethodDecl>(func) : nullptr;
if (!method || method->getNameAsString() != "operator[]")
return;
auto memberExpr = HierarchyUtils::getFirstParentOfType<CXXMemberCallExpr>(m_context->parentMap, operatorExpr);
CXXMethodDecl *parentMemberDecl = memberExpr ? memberExpr->getMethodDecl() : nullptr;
if (parentMemberDecl && !parentMemberDecl->isConst()) {
// Don't warn for s.m_listOfValues[0].nonConstMethod();
// However do warn for: s.m_listOfPointers[0]->nonConstMethod(); because it compiles with .at()
QualType qt = operatorExpr->getType();
const Type *t = qt.getTypePtrOrNull();
if (t && !t->isPointerType())
return;
}
memberDecl = Utils::valueDeclForOperatorCall(operatorExpr);
} else {
method = memberCall->getMethodDecl();
memberDecl = Utils::valueDeclForMemberCall(memberCall);
}
if (!method || !memberDecl || !Utils::isMemberVariable(memberDecl) || !isDetachingMethod(method) || method->isConst())
return;
// Catch cases like m_foo[0] = .. , which is fine
auto parentUnaryOp = HierarchyUtils::getFirstParentOfType<UnaryOperator>(m_context->parentMap, callExpr);
if (parentUnaryOp) {
// m_foo[0]++ is OK
return;
}
auto parentOp = HierarchyUtils::getFirstParentOfType<CXXOperatorCallExpr>(m_context->parentMap, HierarchyUtils::parent(m_context->parentMap, callExpr));
if (parentOp) {
FunctionDecl *parentFunc = parentOp->getDirectCallee();
const string parentFuncName = parentFunc ? parentFunc->getNameAsString() : "";
if (clazy_std::startsWith(parentFuncName, "operator")) {
// m_foo[0] = ... is OK
return;
}
}
auto parentBinaryOp = HierarchyUtils::getFirstParentOfType<BinaryOperator>(m_context->parentMap, callExpr);
if (parentBinaryOp && parentBinaryOp->isAssignmentOp()) {
// m_foo[0] += .. is OK
Expr *lhs = parentBinaryOp->getLHS();
if (callExpr == lhs || HierarchyUtils::isChildOf(callExpr, lhs))
return;
}
const bool returnsNonConstIterator = clazy_std::endsWith(memberCall ? memberCall->getType().getAsString() : "", "::iterator");
if (returnsNonConstIterator) {
// If we're calling begin()/end() as arguments to a function taking non-const iterators it's fine
// Such as qSort(list.begin(), list.end());
auto parentCall = HierarchyUtils::getFirstParentOfType<CallExpr>(m_context->parentMap, HierarchyUtils::parent(m_context->parentMap, memberCall));
FunctionDecl *parentFunc = parentCall ? parentCall->getDirectCallee() : nullptr;
if (parentFunc && parentFunc->getNumParams() == parentCall->getNumArgs()) {
int i = 0;
for (auto argExpr : parentCall->arguments()) {
if (CXXMemberCallExpr *expr2 = HierarchyUtils::getFirstChildOfType<CXXMemberCallExpr>(argExpr)) {
if (expr2 == memberCall) {
// Success, we found which arg
ParmVarDecl *parm = parentFunc->getParamDecl(i);
if (parm->getType().getAsString() == memberCall->getType().getAsString()) {
return;
} else {
break;
}
}
}
++i;
}
}
}
emitWarning(stm->getLocStart(), "Potential detachment due to calling " + method->getQualifiedNameAsString() + "()");
}
REGISTER_CHECK("detaching-member", DetachingMember, CheckLevel3)
|
