1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
|
/*
This file is part of the clazy static checker.
Copyright (C) 2015 Klarälvdalens Datakonsult AB, a KDAB Group company, info@kdab.com
Author: Sérgio Martins <sergio.martins@kdab.com>
Copyright (C) 2015 Sergio Martins <smartins@kde.org>
This library is free software; you can redistribute it and/or
modify it under the terms of the GNU Library General Public
License as published by the Free Software Foundation; either
version 2 of the License, or (at your option) any later version.
This library is distributed in the hope that it will be useful,
but WITHOUT ANY WARRANTY; without even the implied warranty of
MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
Library General Public License for more details.
You should have received a copy of the GNU Library General Public License
along with this library; see the file COPYING.LIB. If not, write to
the Free Software Foundation, Inc., 51 Franklin Street, Fifth Floor,
Boston, MA 02110-1301, USA.
*/
#include "dynamic_cast.h"
#include "Utils.h"
#include "QtUtils.h"
#include "checkmanager.h"
#include "TypeUtils.h"
#include <clang/AST/DeclCXX.h>
#include <clang/AST/ExprCXX.h>
using namespace clang;
BogusDynamicCast::BogusDynamicCast(const std::string &name, ClazyContext *context)
: CheckBase(name, context)
{
}
void BogusDynamicCast::VisitStmt(clang::Stmt *stm)
{
auto dynExp = dyn_cast<CXXDynamicCastExpr>(stm);
if (!dynExp)
return;
auto namedCast = dyn_cast<CXXNamedCastExpr>(stm);
CXXRecordDecl *castFrom = Utils::namedCastInnerDecl(namedCast);
if (!castFrom)
return;
if (isOptionSet("qobject") && QtUtils::isQObject(castFrom)) // Very noisy and not very useful, and qobject_cast can fail too
emitWarning(dynExp->getLocStart(), "Use qobject_cast rather than dynamic_cast");
CXXRecordDecl *castTo = Utils::namedCastOuterDecl(namedCast);
if (!castTo)
return;
if (castFrom == castTo) {
emitWarning(stm->getLocStart(), "Casting to itself");
} else if (TypeUtils::derivesFrom(/*child=*/castFrom, castTo)) {
emitWarning(stm->getLocStart(), "explicitly casting to base is unnecessary");
}
}
REGISTER_CHECK("bogus-dynamic-cast", BogusDynamicCast, CheckLevel3)
|
