1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
|
/*
This file is part of the clazy static checker.
Copyright (C) 2015 Sergio Martins <smartins@kde.org>
This library is free software; you can redistribute it and/or
modify it under the terms of the GNU Library General Public
License as published by the Free Software Foundation; either
version 2 of the License, or (at your option) any later version.
This library is distributed in the hope that it will be useful,
but WITHOUT ANY WARRANTY; without even the implied warranty of
MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
Library General Public License for more details.
You should have received a copy of the GNU Library General Public License
along with this library; see the file COPYING.LIB. If not, write to
the Free Software Foundation, Inc., 51 Franklin Street, Fifth Floor,
Boston, MA 02110-1301, USA.
*/
#include "isempty-vs-count.h"
#include "StringUtils.h"
#include "QtUtils.h"
#include "SourceCompatibilityHelpers.h"
#include <clang/AST/DeclCXX.h>
#include <clang/AST/Expr.h>
#include <clang/AST/ExprCXX.h>
#include <clang/AST/OperationKinds.h>
#include <clang/AST/Stmt.h>
#include <clang/AST/StmtIterator.h>
#include <clang/Basic/LLVM.h>
#include <llvm/ADT/StringRef.h>
#include <llvm/Support/Casting.h>
class ClazyContext;
using namespace clang;
using namespace std;
IsEmptyVSCount::IsEmptyVSCount(const std::string &name, ClazyContext *context)
: CheckBase(name, context, Option_CanIgnoreIncludes)
{
}
void IsEmptyVSCount::VisitStmt(clang::Stmt *stmt)
{
auto cast = dyn_cast<ImplicitCastExpr>(stmt);
if (!cast || cast->getCastKind() != clang::CK_IntegralToBoolean)
return;
auto memberCall = dyn_cast<CXXMemberCallExpr>(*(cast->child_begin()));
CXXMethodDecl *method = memberCall ? memberCall->getMethodDecl() : nullptr;
if (!clazy::functionIsOneOf(method, {"size", "count", "length"}))
return;
if (!clazy::classIsOneOf(method->getParent(), clazy::qtContainers()))
return;
emitWarning(getLocStart(stmt), "use isEmpty() instead");
}
|
