diff options
author | Andrzej WarzyĆski <andrzej.warzynski@arm.com> | 2024-04-08 13:59:27 +0100 |
---|---|---|
committer | GitHub <noreply@github.com> | 2024-04-08 13:59:27 +0100 |
commit | 662c62609e8ee2dc996da69e11c0d594e799c299 (patch) | |
tree | a712219388810967610643455a4108456a5bde1c | |
parent | eb07600f8eff793664a4d6b181e6f31de1f5f973 (diff) |
[mlir][arith] Refine the verifier for arith.constant (#86178)
Disallows initialization of scalable vectors with an attribute of
arbitrary values, e.g.:
```mlir
%c = arith.constant dense<[0, 1]> : vector<[2] x i32>
```
Initialization using vector splats remains allowed (i.e. when all the
init values are identical):
```mlir
%c = arith.constant dense<[1, 1]> : vector<[2] x i32>
```
-rw-r--r-- | mlir/lib/Dialect/Arith/IR/ArithOps.cpp | 6 | ||||
-rw-r--r-- | mlir/test/Dialect/Arith/invalid.mlir | 9 |
2 files changed, 15 insertions, 0 deletions
diff --git a/mlir/lib/Dialect/Arith/IR/ArithOps.cpp b/mlir/lib/Dialect/Arith/IR/ArithOps.cpp index 1d68a4f7292b..efc4bfe622d5 100644 --- a/mlir/lib/Dialect/Arith/IR/ArithOps.cpp +++ b/mlir/lib/Dialect/Arith/IR/ArithOps.cpp @@ -213,6 +213,12 @@ LogicalResult arith::ConstantOp::verify() { return emitOpError( "value must be an integer, float, or elements attribute"); } + + auto vecType = dyn_cast<VectorType>(type); + if (vecType && vecType.isScalable() && !isa<SplatElementsAttr>(getValue())) + return emitOpError( + "intializing scalable vectors with elements attribute is not supported" + " unless it's a vector splat"); return success(); } diff --git a/mlir/test/Dialect/Arith/invalid.mlir b/mlir/test/Dialect/Arith/invalid.mlir index 6d8ac0ada52b..fdc907a7c6af 100644 --- a/mlir/test/Dialect/Arith/invalid.mlir +++ b/mlir/test/Dialect/Arith/invalid.mlir @@ -64,6 +64,15 @@ func.func @constant_out_of_range() { // ----- +func.func @constant_invalid_scalable_vec_initialization() { +^bb0: + // expected-error@+1 {{'arith.constant' op intializing scalable vectors with elements attribute is not supported unless it's a vector splat}} + %c = arith.constant dense<[0, 1]> : vector<[2] x i32> + return +} + +// ----- + func.func @constant_wrong_type() { ^bb: %x = "arith.constant"(){value = 10.} : () -> f32 // expected-error {{'arith.constant' op failed to verify that all of {value, result} have same type}} |