summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorVitaly Buka <vitalybuka@google.com>2023-11-28 17:04:44 -0800
committerVitaly Buka <vitalybuka@google.com>2023-11-28 17:04:44 -0800
commit0aee7158c8edf7929ba6b0d324edde21eba30093 (patch)
treed8087997ff3932e7f5b451e78301541d68e23a2b
parentfea023b129190edeb503dbe947034f925bbda666 (diff)
[𝘀𝗽𝗿] changes to main this commit is based onupstream/users/vitalybuka/spr/main.msan-intercept-mallinfo2
Created using spr 1.3.4 [skip ci]
-rw-r--r--compiler-rt/lib/msan/msan_interceptors.cpp27
-rw-r--r--compiler-rt/test/msan/Linux/mallinfo.cpp1
2 files changed, 15 insertions, 13 deletions
diff --git a/compiler-rt/lib/msan/msan_interceptors.cpp b/compiler-rt/lib/msan/msan_interceptors.cpp
index bac756424e28..dfecf6f7c470 100644
--- a/compiler-rt/lib/msan/msan_interceptors.cpp
+++ b/compiler-rt/lib/msan/msan_interceptors.cpp
@@ -244,20 +244,23 @@ INTERCEPTOR(uptr, malloc_usable_size, void *ptr) {
#endif
#if !SANITIZER_FREEBSD && !SANITIZER_NETBSD
-// This function actually returns a struct by value, but we can't unpoison a
-// temporary! The following is equivalent on all supported platforms but
-// aarch64 (which uses a different register for sret value). We have a test
-// to confirm that.
-INTERCEPTOR(void, mallinfo, __sanitizer_struct_mallinfo *sret) {
-#ifdef __aarch64__
- uptr r8;
- asm volatile("mov %0,x8" : "=r" (r8));
- sret = reinterpret_cast<__sanitizer_struct_mallinfo*>(r8);
-#endif
- REAL(memset)(sret, 0, sizeof(*sret));
+
+template <class T>
+static NOINLINE void clear_mallinfo(T *sret) {
+ ENSURE_MSAN_INITED();
+ internal_memset(sret, 0, sizeof(*sret));
__msan_unpoison(sret, sizeof(*sret));
}
-#define MSAN_MAYBE_INTERCEPT_MALLINFO INTERCEPT_FUNCTION(mallinfo)
+
+// Interceptor relies on NRVO and assumes that sret will be pre-allocated in
+// caller frame.
+INTERCEPTOR(__sanitizer_struct_mallinfo, mallinfo) {
+ __sanitizer_struct_mallinfo sret;
+ clear_mallinfo(&sret);
+ return sret;
+}
+
+# define MSAN_MAYBE_INTERCEPT_MALLINFO INTERCEPT_FUNCTION(mallinfo)
#else
#define MSAN_MAYBE_INTERCEPT_MALLINFO
#endif
diff --git a/compiler-rt/test/msan/Linux/mallinfo.cpp b/compiler-rt/test/msan/Linux/mallinfo.cpp
index b2021c5df3ce..3c3692969852 100644
--- a/compiler-rt/test/msan/Linux/mallinfo.cpp
+++ b/compiler-rt/test/msan/Linux/mallinfo.cpp
@@ -1,5 +1,4 @@
// RUN: %clangxx_msan -O0 -g %s -o %t && %run %t
-// UNSUPPORTED: aarch64-target-arch
#include <assert.h>
#include <malloc.h>