diff options
author | Scott Douglass <sdouglass@arm.com> | 2015-07-01 13:41:18 +0000 |
---|---|---|
committer | Scott Douglass <sdouglass@arm.com> | 2015-07-01 13:41:18 +0000 |
commit | 7e6843cbd6895104c6ecda6d760447733fd988d0 (patch) | |
tree | a9c74c0b2db689f2f84f5921d2cc422a316cffb9 /docs/Phabricator.rst | |
parent | 2ae30810d8ff13af5ff3f4f5d6b645fc3288d1fa (diff) |
Expand Phabricator docs slightly
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@241161 91177308-0d34-0410-b5e6-96231b3b80d8
Diffstat (limited to 'docs/Phabricator.rst')
-rw-r--r-- | docs/Phabricator.rst | 16 |
1 files changed, 9 insertions, 7 deletions
diff --git a/docs/Phabricator.rst b/docs/Phabricator.rst index f7238afafc7e..1dcd6a0859d1 100644 --- a/docs/Phabricator.rst +++ b/docs/Phabricator.rst @@ -60,26 +60,28 @@ to upload your patch): To upload a new patch: * Click *Differential*. -* Click *Create Diff*. -* Paste the text diff or upload the patch file. - Note that TODO +* Click *+ Create Diff*. +* Paste the text diff or browse to the patch file. Click *Create Diff*. +* Leave the Repository field blank. * Leave the drop down on *Create a new Revision...* and click *Continue*. * Enter a descriptive title and summary. The title and summary are usually in the form of a :ref:`commit message <commit messages>`. * Add reviewers and mailing lists that you want to be included in the review. If your patch is - for LLVM, add llvm-commits as a subscriber; if your patch is for Clang, + for LLVM, add llvm-commits as a Subscriber; if your patch is for Clang, add cfe-commits. +* Leave the Repository and Project fields blank. * Click *Save*. To submit an updated patch: * Click *Differential*. -* Click *Create Diff*. -* Paste the updated diff. +* Click *+ Create Diff*. +* Paste the updated diff or browse to the updated patch file. Click *Create Diff*. * Select the review you want to from the *Attach To* dropdown and click *Continue*. -* Click *Save*. +* Leave the Repository and Project fields blank. +* Add comments about the changes in the new diff. Click *Save*. Reviewing code with Phabricator ------------------------------- |