diff options
| author | Justin Bogner <mail@justinbogner.com> | 2016-05-05 23:19:08 +0000 |
|---|---|---|
| committer | Justin Bogner <mail@justinbogner.com> | 2016-05-05 23:19:08 +0000 |
| commit | 9ed38db20eac20ba78c7daf6970324612cd0d60f (patch) | |
| tree | a21465c567b1fdc4596ccc85cef8ba0757ec7c88 /docs/ReleaseNotes.rst | |
| parent | 5f2e6ee2b7ca824a40d8d2ef4451cb735b048648 (diff) | |
SDAG: Rename Select->SelectImpl and repurpose Select as returning void
This is a step towards removing the rampant undefined behaviour in
SelectionDAG, which is a part of llvm.org/PR26808.
We rename SelectionDAGISel::Select to SelectImpl and update targets to
match, and then change Select to return void and consolidate the
sketchy behaviour we're trying to get away from there.
Next, we'll update backends to implement `void Select(...)` instead of
SelectImpl and eventually drop the base Select implementation.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@268693 91177308-0d34-0410-b5e6-96231b3b80d8
Diffstat (limited to 'docs/ReleaseNotes.rst')
| -rw-r--r-- | docs/ReleaseNotes.rst | 4 |
1 files changed, 4 insertions, 0 deletions
diff --git a/docs/ReleaseNotes.rst b/docs/ReleaseNotes.rst index 6d1f74c7d0a4..1f88ec1048d4 100644 --- a/docs/ReleaseNotes.rst +++ b/docs/ReleaseNotes.rst @@ -61,6 +61,10 @@ Non-comprehensive list of changes in this release iterator to the next instruction instead of ``void``. Targets that previously did ``MBB.erase(I); return;`` now probably want ``return MBB.erase(I);``. +* ``SelectionDAGISel::Select`` now returns ``void``. Out of tree targets will + need to be updated to replace the argument node and remove any dead nodes in + cases where they currently return an ``SDNode *`` from this interface. + .. NOTE For small 1-3 sentence descriptions, just add an entry at the end of this list. If your description won't fit comfortably in one bullet |