diff options
| author | Teresa Johnson <tejohnson@google.com> | 2016-07-13 16:35:56 +0000 |
|---|---|---|
| committer | Teresa Johnson <tejohnson@google.com> | 2016-07-13 16:35:56 +0000 |
| commit | 929c94185676b691b26392cb013a20054ca86512 (patch) | |
| tree | b0eec0639b355558c11100a96cd42ef45a4d4c48 /tools/gold | |
| parent | 2ca896a1759c9ba3901e43d184c383f22e73f2bb (diff) | |
[ThinLTO/gold] Enable symbol resolution in distributed backend case
While testing a follow-on change to enable index-based symbol resolution
and internalization in the distributed backends, I realized that a test
case change I made in r275247 was only required because we were not
analyzing symbols in the claimed files in thinlto-index-only mode.
In the fixed test case there should be no internalization because we are
linking in -shared mode, so f() is in fact exported, which is detected
properly when we analyze symbols in thinlto-index-only mode. Note that
this is not (yet) a correctness issue (because we are not yet performing
the index-based linkage optimizations in the distributed backends -
that's coming in a follow-on patch).
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@275277 91177308-0d34-0410-b5e6-96231b3b80d8
Diffstat (limited to 'tools/gold')
| -rw-r--r-- | tools/gold/gold-plugin.cpp | 5 |
1 files changed, 0 insertions, 5 deletions
diff --git a/tools/gold/gold-plugin.cpp b/tools/gold/gold-plugin.cpp index 4fff5dcf900c..dfe3d6f6971b 100644 --- a/tools/gold/gold-plugin.cpp +++ b/tools/gold/gold-plugin.cpp @@ -524,11 +524,6 @@ static ld_plugin_status claim_file_hook(const ld_plugin_input_file *file, cf.name += ".llvm." + std::to_string(file->offset) + "." + sys::path::filename(Obj->getModule().getSourceFileName()).str(); - // If we are doing ThinLTO compilation, don't need to process the symbols. - // Later we simply build a combined index file after all files are claimed. - if (options::thinlto && options::thinlto_index_only) - return LDPS_OK; - for (auto &Sym : Obj->symbols()) { uint32_t Symflags = Sym.getFlags(); if (shouldSkip(Symflags)) |