summaryrefslogtreecommitdiffstats
path: root/unittests
diff options
context:
space:
mode:
authorVedant Kumar <vsk@apple.com>2017-07-10 21:44:43 +0000
committerVedant Kumar <vsk@apple.com>2017-07-10 21:44:43 +0000
commitcdcc59f9d06b46b90cc89c447ab658c53a995045 (patch)
tree7d4f2709b3529d88a859663cc2dd2da4d86240df /unittests
parent8a3ff6431f415939238052f7a262876dd775617d (diff)
InstrProf: Fix unit test which accidentally used a duplicate name
This unit test constructed some profile records incorrectly. One of the records had a duplicate name: adding that record into the writer caused an error unrelated to what needed to be tested. Reported by David Blaikie! git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@307596 91177308-0d34-0410-b5e6-96231b3b80d8
Diffstat (limited to 'unittests')
-rw-r--r--unittests/ProfileData/InstrProfTest.cpp5
1 files changed, 1 insertions, 4 deletions
diff --git a/unittests/ProfileData/InstrProfTest.cpp b/unittests/ProfileData/InstrProfTest.cpp
index 71795b01ba8b..79f880e475c6 100644
--- a/unittests/ProfileData/InstrProfTest.cpp
+++ b/unittests/ProfileData/InstrProfTest.cpp
@@ -996,10 +996,7 @@ TEST_P(MaybeSparseInstrProfTest, instr_prof_symtab_compression_test) {
TEST_F(SparseInstrProfTest, preserve_no_records) {
Writer.addRecord({"foo", 0x1234, {0}}, Err);
Writer.addRecord({"bar", 0x4321, {0, 0}}, Err);
- // FIXME: I'm guessing this data should be different, but the original author
- // should check/update this test so it doesn't produce errors.
- Writer.addRecord({"bar", 0x4321, {0, 0, 0}},
- [](Error E) { consumeError(std::move(E)); });
+ Writer.addRecord({"baz", 0x4321, {0, 0, 0}}, Err);
auto Profile = Writer.writeBuffer();
readProfile(std::move(Profile));