Fix crash while deleting components.

To delete it's childs, the component uses qDeleteAll on the childs list,
but once a child get's deleted it removes itself from the calling
components child list and then messes up the list iterators. The child
list passed to qDeleteAll needs to be a deep copy of the list the
component owns to not mess with the original the calliing component holds.

Change-Id: I638ffbb576a9543b7197c8bf267239f31197e274
Reviewed-by: Karsten Heimrich <karsten.heimrich@nokia.com>

1 files changed, 7 insertions, 1 deletions

diff --git a/installerbuilder/libinstaller/component.cpp b/installerbuilder/libinstaller/component.cpp
index b0284286e..2398a7c62 100644
--- a/installerbuilder/libinstaller/component.cpp
+++ b/installerbuilder/libinstaller/component.cpp
@@ -94,8 +94,14 @@ Component::~Component()
     if (!d->m_newlyInstalled)
         qDeleteAll(d->m_operations);
 
-    qDeleteAll(d->m_allChildComponents);
+    //we need to copy the list, because we are changing it with removeAll at top
+    //(this made the iterators broken in the past)
+    QList<Component*> copiedChildrenList = d->m_allChildComponents;
+    copiedChildrenList.detach(); //this makes it a real copy
+
+    qDeleteAll(copiedChildrenList);
     delete d;
+    d = 0;
 }
 
 void Component::loadDataFromPackage(const LocalPackage &package)