diff options
author | Niels Weber <niels.weber@digia.com> | 2013-03-11 13:35:51 +0100 |
---|---|---|
committer | Niels Weber <niels.weber@digia.com> | 2013-03-11 15:16:13 +0100 |
commit | fda13bf44020c4dea270916b8866c26d5da0c011 (patch) | |
tree | d472749c0154ca7897e9d58fc06df009684374f0 | |
parent | e3ac9a913c677d221d080cef15ec7b5006ab4c66 (diff) |
Make some constructors explicit
As recommended by krazy run.
Change-Id: If4acdf487e998d0c52b5443322cbde95b6e961fa
Reviewed-by: Kai Koehne <kai.koehne@digia.com>
Reviewed-by: Karsten Heimrich <karsten.heimrich@digia.com>
-rw-r--r-- | src/libs/installer/binaryformat.h | 2 | ||||
-rw-r--r-- | src/libs/installer/link.h | 2 | ||||
-rw-r--r-- | src/libs/installer/packagemanagerproxyfactory.h | 2 | ||||
-rw-r--r-- | src/libs/installer/performinstallationform.h | 2 | ||||
-rw-r--r-- | src/libs/installer/utils.h | 2 | ||||
-rw-r--r-- | src/sdk/installerbase_p.h | 2 | ||||
-rw-r--r-- | src/sdk/settingsdialog.h | 10 | ||||
-rw-r--r-- | tools/repogenfromonlinerepo/downloadmanager.h | 2 |
8 files changed, 12 insertions, 12 deletions
diff --git a/src/libs/installer/binaryformat.h b/src/libs/installer/binaryformat.h index 49be60a06..d255ea8a9 100644 --- a/src/libs/installer/binaryformat.h +++ b/src/libs/installer/binaryformat.h @@ -203,7 +203,7 @@ class INSTALLER_EXPORT BinaryContentPrivate : public QSharedData { public: BinaryContentPrivate(); - BinaryContentPrivate(const QString &path); + explicit BinaryContentPrivate(const QString &path); BinaryContentPrivate(const BinaryContentPrivate &other); ~BinaryContentPrivate(); diff --git a/src/libs/installer/link.h b/src/libs/installer/link.h index fc8d8fee3..e359c8f91 100644 --- a/src/libs/installer/link.h +++ b/src/libs/installer/link.h @@ -47,7 +47,7 @@ class Link { public: - Link(const QString &path); + explicit Link(const QString &path); static Link create(const QString &link, const QString &targetPath); QString targetPath() const; bool targetExists(); diff --git a/src/libs/installer/packagemanagerproxyfactory.h b/src/libs/installer/packagemanagerproxyfactory.h index 2ddfe7a18..a50605232 100644 --- a/src/libs/installer/packagemanagerproxyfactory.h +++ b/src/libs/installer/packagemanagerproxyfactory.h @@ -51,7 +51,7 @@ class PackageManagerCore; class PackageManagerProxyFactory : public KDUpdater::FileDownloaderProxyFactory { public: - PackageManagerProxyFactory(const PackageManagerCore *const core); + explicit PackageManagerProxyFactory(const PackageManagerCore *const core); PackageManagerProxyFactory *clone() const; QList<QNetworkProxy> queryProxy(const QNetworkProxyQuery &query = QNetworkProxyQuery()); diff --git a/src/libs/installer/performinstallationform.h b/src/libs/installer/performinstallationform.h index f3471ebe2..209afc42d 100644 --- a/src/libs/installer/performinstallationform.h +++ b/src/libs/installer/performinstallationform.h @@ -61,7 +61,7 @@ class PerformInstallationForm : public QObject Q_OBJECT public: - PerformInstallationForm(QObject *parent); + explicit PerformInstallationForm(QObject *parent); void setupUi(QWidget *widget); void setDetailsWidgetVisible(bool visible); diff --git a/src/libs/installer/utils.h b/src/libs/installer/utils.h index 0d21adbee..e6aca456d 100644 --- a/src/libs/installer/utils.h +++ b/src/libs/installer/utils.h @@ -81,7 +81,7 @@ namespace QInstaller { { Q_OBJECT public: - VerboseWriter(QObject *parent = 0); + explicit VerboseWriter(QObject *parent = 0); ~VerboseWriter(); static VerboseWriter *instance(); diff --git a/src/sdk/installerbase_p.h b/src/sdk/installerbase_p.h index bea4c862f..cd6ed0142 100644 --- a/src/sdk/installerbase_p.h +++ b/src/sdk/installerbase_p.h @@ -66,7 +66,7 @@ class InstallerBase : public QObject Q_OBJECT public: - InstallerBase(QObject *parent = 0); + explicit InstallerBase(QObject *parent = 0); ~InstallerBase(); int replaceMaintenanceToolBinary(QStringList arguments); diff --git a/src/sdk/settingsdialog.h b/src/sdk/settingsdialog.h index f0d068a78..1a6633c67 100644 --- a/src/sdk/settingsdialog.h +++ b/src/sdk/settingsdialog.h @@ -77,7 +77,7 @@ class TestRepository : public KDJob public: - TestRepository(QObject *parent = 0); + explicit TestRepository(QObject *parent = 0); ~TestRepository(); QInstaller::Repository repository() const; @@ -105,7 +105,7 @@ class PasswordDelegate : public QStyledItemDelegate Q_OBJECT public: - PasswordDelegate(QWidget *parent = 0) + explicit PasswordDelegate(QWidget *parent = 0) : QStyledItemDelegate(parent) , m_showPasswords(true) , m_disabledEditor(true) @@ -129,8 +129,8 @@ private: class RepositoryItem : public QTreeWidgetItem { public: - RepositoryItem(const QString &label); - RepositoryItem(const QInstaller::Repository &repo); + explicit RepositoryItem(const QString &label); + explicit RepositoryItem(const QInstaller::Repository &repo); QVariant data(int column, int role) const; void setData(int column, int role, const QVariant &value); @@ -151,7 +151,7 @@ class SettingsDialog : public QDialog Q_OBJECT public: - SettingsDialog(QInstaller::PackageManagerCore *core, QWidget *parent = 0); + explicit SettingsDialog(QInstaller::PackageManagerCore *core, QWidget *parent = 0); public slots: void accept(); diff --git a/tools/repogenfromonlinerepo/downloadmanager.h b/tools/repogenfromonlinerepo/downloadmanager.h index 13cce7163..29aebec45 100644 --- a/tools/repogenfromonlinerepo/downloadmanager.h +++ b/tools/repogenfromonlinerepo/downloadmanager.h @@ -54,7 +54,7 @@ class DownloadManager: public QObject { Q_OBJECT public: - DownloadManager(QObject *parent = 0); + explicit DownloadManager(QObject *parent = 0); void append(const QUrl &url); void append(const QStringList &urlList); |