diff options
| author | Katja Marttila <katja.marttila@qt.io> | 2018-10-25 11:31:07 +0300 |
|---|---|---|
| committer | Katja Marttila <katja.marttila@qt.io> | 2018-10-29 08:29:25 +0000 |
| commit | a16f67ea99b6599b725ce762b520beafb34f6427 (patch) | |
| tree | 701c8bc83cbbf37eb3af6a9451839e3fdf6ca7a4 | |
| parent | 3053efe754bfac6f0d7faa07bbcece3ebfd30270 (diff) | |
Do not compare empty target to QDir::root() or QDir::home()
Comparing empty target will cause 'Empty filename passed to function'
warning in unix.
Change-Id: I2ee1490ef342031703638c201b5e2d6d745a1c98
Reviewed-by: Antti Kokko <antti.kokko@qt.io>
| -rw-r--r-- | src/libs/installer/packagemanagergui.cpp | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/src/libs/installer/packagemanagergui.cpp b/src/libs/installer/packagemanagergui.cpp index a7a0aa45e..430008cdb 100644 --- a/src/libs/installer/packagemanagergui.cpp +++ b/src/libs/installer/packagemanagergui.cpp @@ -2233,7 +2233,7 @@ QString TargetDirectoryPage::targetDirWarning() const } target = target.canonicalPath(); - if (target == QDir::root() || target == QDir::home()) { + if (!target.isEmpty() && (target == QDir::root() || target == QDir::home())) { return tr("As the install directory is completely deleted, installing in %1 is forbidden.") .arg(QDir::toNativeSeparators(target.path())); } |