summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorKatja Marttila <katja.marttila@qt.io>2019-12-10 12:23:08 +0200
committerKatja Marttila <katja.marttila@qt.io>2019-12-12 15:46:15 +0000
commit4744ad130a2d4310e812a89da22d36a2e885b281 (patch)
treec06e6dfaaf25f6cd00223a9386e222d9d56eebb5
parentd05dd83ea23897c1e5a893c29fa0f606f6a496b7 (diff)
Do not show error dialog when filelist for uninstall not found3.2.0
This error can occur for example when user has manually deleted the installerResource folder or files inside it or the same component has been installed multiple times (QTIFW-1502). Change-Id: I8007a2f99517b4f90902ed3b740027d54371d119 Reviewed-by: Jani Heikkinen <jani.heikkinen@qt.io>
-rw-r--r--src/libs/installer/extractarchiveoperation.cpp9
1 files changed, 5 insertions, 4 deletions
diff --git a/src/libs/installer/extractarchiveoperation.cpp b/src/libs/installer/extractarchiveoperation.cpp
index ba0591c84..b5bf96954 100644
--- a/src/libs/installer/extractarchiveoperation.cpp
+++ b/src/libs/installer/extractarchiveoperation.cpp
@@ -212,10 +212,11 @@ bool ExtractArchiveOperation::readDataFileContents(QString &targetDir, QStringLi
resultList->replace(i, replacePath(resultList->at(i), QLatin1String(scRelocatable), targetDir));
} else {
- setError(UserDefinedError);
- setErrorString(tr("Cannot open file \"%1\" for reading: %2")
- .arg(QDir::toNativeSeparators(file.fileName())).arg(file.errorString()));
- return false;
+ // We should not be here. Either user has manually deleted the installer related
+ // files or same component is installed several times.
+ qWarning() << "Cannot open file " << file.fileName() << " for reading:"
+ << file.errorString() << ". Component is already uninstalled "
+ << "or file is manually deleted.";
}
return true;
}