summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorKatja Marttila <katja.marttila@qt.io>2019-01-25 14:31:43 +0200
committerKatja Marttila <katja.marttila@qt.io>2019-01-28 06:46:37 +0000
commit086a3e43ad2d501a5d2889be72f4b07b05d06e26 (patch)
tree24acd6bcaad2eaeadf2db9997e914bdd34dda33a
parent3d8c194690a43a6d2c48f808b02a4084bbf0142f (diff)
Reset error before every new metadata job
Installer crashed when invalid QBSP package was selected and after that new categories were fetched. This was because the error message was not cleared, although the metadata job was succesfull, installer thought there was still problems causing it to eventually crash. Task-number: QTIFW-1272 Change-Id: I8a5a6fd8568dcabd9c857c462b83d0e0b77669f8 Reviewed-by: Iikka Eklund <iikka.eklund@qt.io>
-rw-r--r--src/libs/installer/metadatajob.cpp2
1 files changed, 2 insertions, 0 deletions
diff --git a/src/libs/installer/metadatajob.cpp b/src/libs/installer/metadatajob.cpp
index 7b80eefa9..0a03e54cf 100644
--- a/src/libs/installer/metadatajob.cpp
+++ b/src/libs/installer/metadatajob.cpp
@@ -102,6 +102,8 @@ Repository MetadataJob::repositoryForDirectory(const QString &directory) const
void MetadataJob::doStart()
{
+ setError(Job::NoError);
+ setErrorString(QString());
if (!m_core) {
emitFinishedWithError(Job::Canceled, tr("Missing package manager core engine."));
return; // We can't do anything here without core, so avoid tons of !m_core checks.