summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorArttu Tarkiainen <arttu.tarkiainen@qt.io>2020-10-16 11:22:26 +0300
committerArttu Tarkiainen <arttu.tarkiainen@qt.io>2020-10-16 11:28:12 +0300
commitdb4b699684029e447b7f180b9b00e2ebc5533175 (patch)
tree82d63692637904abd0961e4720dde58d14754016
parent1e60013b8bf7125b8bcaed037a59001f856bb951 (diff)
Fix segfault in 'void localSocket()' test function
Change-Id: Iced229d7d364f68599bd6eec20db57838f36a671 Reviewed-by: Katja Marttila <katja.marttila@qt.io>
-rw-r--r--tests/auto/installer/clientserver/tst_clientserver.cpp64
1 files changed, 31 insertions, 33 deletions
diff --git a/tests/auto/installer/clientserver/tst_clientserver.cpp b/tests/auto/installer/clientserver/tst_clientserver.cpp
index b3e220c9f..23442d5fa 100644
--- a/tests/auto/installer/clientserver/tst_clientserver.cpp
+++ b/tests/auto/installer/clientserver/tst_clientserver.cpp
@@ -153,44 +153,42 @@ private slots:
const QByteArray message(10905, '0');
QLocalServer server;
- { // server
- QLocalSocket *rcv = 0;
- auto srvDataArrived = [&]() {
- QByteArray command, message;
- if (!receivePacket(rcv, &command, &message))
- return;
- sendPacket(rcv, command, message);
- };
-
- connect(&server, &QLocalServer::newConnection, [&,srvDataArrived]() {
- rcv = server.nextPendingConnection();
- connect(rcv, &QLocalSocket::readyRead, srvDataArrived);
- });
+ // server
+ QLocalSocket *rcv = 0;
+ auto srvDataArrived = [&]() {
+ QByteArray command, message;
+ if (!receivePacket(rcv, &command, &message))
+ return;
+ sendPacket(rcv, command, message);
+ };
- server.listen(socketName);
- }
+ connect(&server, &QLocalServer::newConnection, [&,srvDataArrived]() {
+ rcv = server.nextPendingConnection();
+ connect(rcv, &QLocalSocket::readyRead, srvDataArrived);
+ });
+
+ server.listen(socketName);
QLocalSocket snd;
- { // client
- auto clientDataArrived = [&]() {
- QByteArray cmd, msg;
- if (!receivePacket(&snd, &cmd, &msg))
- return;
- QCOMPARE(cmd, command);
- QCOMPARE(msg, message);
- loop.exit();
- };
-
- connect(&snd, &QLocalSocket::readyRead, clientDataArrived);
-
- QTimer::singleShot(0, [&]() {
- snd.connect(&snd, &QLocalSocket::connected, [&](){
- sendPacket(&snd, command, message);
- });
- snd.connectToServer(socketName);
+ // client
+ auto clientDataArrived = [&]() {
+ QByteArray cmd, msg;
+ if (!receivePacket(&snd, &cmd, &msg))
+ return;
+ QCOMPARE(cmd, command);
+ QCOMPARE(msg, message);
+ loop.exit();
+ };
+
+ connect(&snd, &QLocalSocket::readyRead, clientDataArrived);
+
+ QTimer::singleShot(0, [&]() {
+ snd.connect(&snd, &QLocalSocket::connected, [&](){
+ sendPacket(&snd, command, message);
});
- }
+ snd.connectToServer(socketName);
+ });
loop.exec();
}