summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorAndy Shaw <andy.shaw@qt.io>2020-07-06 12:28:42 +0200
committerAndy Shaw <andy.shaw@qt.io>2020-08-20 15:15:01 +0200
commit190b643736d7fa3270dca5926e018d6eef6d74cb (patch)
tree558d229cf0736b18e421c8ef243af16827d5eff4
parent9cb818812e3354bca526fb6cbff51d865f7a0601 (diff)
Call value() to get a QStringList and not values()
values() returns a QVariantList which has a single QVariant in it which represents the QStringList. So to get the actual QStringList we should call value() on the data so it can be convertable. Change-Id: Ie60889d25b1e03415624fcb2c57117fa7c326efa Reviewed-by: Arttu Tarkiainen <arttu.tarkiainen@qt.io>
-rw-r--r--src/libs/installer/settings.cpp4
1 files changed, 2 insertions, 2 deletions
diff --git a/src/libs/installer/settings.cpp b/src/libs/installer/settings.cpp
index 4b19cafe1..19918c3f9 100644
--- a/src/libs/installer/settings.cpp
+++ b/src/libs/installer/settings.cpp
@@ -514,7 +514,7 @@ QString Settings::runProgram() const
QStringList Settings::runProgramArguments() const
{
- const QVariant variant = d->m_data.values(scRunProgramArguments);
+ const QVariant variant = d->m_data.value(scRunProgramArguments);
if (variant.canConvert<QStringList>())
return variant.value<QStringList>();
return QStringList();
@@ -848,7 +848,7 @@ void Settings::setHttpProxy(const QNetworkProxy &proxy)
QStringList Settings::translations() const
{
- const QVariant variant = d->m_data.values(scTranslations);
+ const QVariant variant = d->m_data.value(scTranslations);
if (variant.canConvert<QStringList>())
return variant.value<QStringList>();
return QStringList();