summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorArttu Tarkiainen <arttu.tarkiainen@qt.io>2022-02-09 13:46:16 +0200
committerArttu Tarkiainen <arttu.tarkiainen@qt.io>2022-02-21 15:37:18 +0200
commit139438b6ea6b16d6c1de0994e091b444d666ef0d (patch)
treeb3ff7fdf2446b1d4c56b5c4abf68d8ce61c5ac9f
parentba6bd5417fddd7138c5c5ded3becf64cfd6fc3c6 (diff)
CLI: Fix missing warnings when trying to install invalid components
If there was at least one valid component argument, the installer would silently ignore any invalid component arguments. Instead print the appropriate "cannot install" reason for such components but still don't block installation for others. Change-Id: I7325d151385744ac46fcb5fa04c0eaf6acade3f3 Reviewed-by: Katja Marttila <katja.marttila@qt.io>
-rw-r--r--src/libs/installer/packagemanagercore.cpp2
1 files changed, 2 insertions, 0 deletions
diff --git a/src/libs/installer/packagemanagercore.cpp b/src/libs/installer/packagemanagercore.cpp
index 5e98ea1de..d2c732ddb 100644
--- a/src/libs/installer/packagemanagercore.cpp
+++ b/src/libs/installer/packagemanagercore.cpp
@@ -2702,6 +2702,8 @@ PackageManagerCore::Status PackageManagerCore::installSelectedComponentsSilently
QString errorMessage;
if (checkComponentsForInstallation(components, errorMessage)) {
+ if (!errorMessage.isEmpty())
+ qCDebug(QInstaller::lcInstallerInstallLog).noquote().nospace() << errorMessage;
if (d->calculateComponentsAndRun())
qCDebug(QInstaller::lcInstallerInstallLog) << "Components installed successfully";
} else {