diff options
| author | Katja Marttila <katja.marttila@qt.io> | 2022-11-07 12:36:14 +0200 |
|---|---|---|
| committer | Katja Marttila <katja.marttila@qt.io> | 2022-11-07 13:44:12 +0200 |
| commit | 19c6d36d03ef2dc55fdd30761ba38968aa12356c (patch) | |
| tree | 76f6bd4641a18e8617ce8e4d2b47f13ca5df17c5 | |
| parent | e72eb190bbefd628479f51fbb504be14eeb0bea2 (diff) | |
Use qAsConst to avoid containers from detaching
Change-Id: I22dba356f434e65cf4db117c42b55f13f07c4e18
Reviewed-by: Arttu Tarkiainen <arttu.tarkiainen@qt.io>
| -rw-r--r-- | src/libs/ifwtools/repositorygen.cpp | 2 | ||||
| -rw-r--r-- | src/libs/installer/component.cpp | 4 |
2 files changed, 3 insertions, 3 deletions
diff --git a/src/libs/ifwtools/repositorygen.cpp b/src/libs/ifwtools/repositorygen.cpp index 8c629edc4..c54fb846b 100644 --- a/src/libs/ifwtools/repositorygen.cpp +++ b/src/libs/ifwtools/repositorygen.cpp @@ -188,7 +188,7 @@ static bool findMetaFile(const QString &repositoryDir, const QDomElement &packag const QDomNodeList c1 = packageUpdate.childNodes(); for (int i = 0; i < c1.count(); ++i) { const QDomElement e1 = c1.at(i).toElement(); - for (const QString &meta : *scMetaElements) { + for (const QString &meta : qAsConst(*scMetaElements)) { if (e1.tagName() == meta) { metaElementFound = true; break; diff --git a/src/libs/installer/component.cpp b/src/libs/installer/component.cpp index c570a5c1f..2ce948e7e 100644 --- a/src/libs/installer/component.cpp +++ b/src/libs/installer/component.cpp @@ -767,7 +767,7 @@ void Component::loadLicenses(const QString &directory, const QHash<QString, QVar */ void Component::loadXMLOperations() { - for (auto operation: m_operationsList) { + for (auto operation: qAsConst(m_operationsList)) { if (operation.first != QLatin1String("Extract")) addOperation(operation.first, operation.second.toStringList()); } @@ -779,7 +779,7 @@ void Component::loadXMLOperations() */ void Component::loadXMLExtractOperations() { - for (auto operation: m_operationsList) { + for (auto &operation: qAsConst(m_operationsList)) { if (operation.first == QLatin1String("Extract")) { // Create hash for Extract operations. Operation has a mandatory extract folder as // first argument and optional archive name as second argument. |