diff options
| author | Morten Johan Sørvig <morten.sorvig@qt.io> | 2018-10-26 11:41:01 +0200 |
|---|---|---|
| committer | Katja Marttila <katja.marttila@qt.io> | 2018-11-05 13:08:30 +0000 |
| commit | a2b41038222b43dd593e57a586a9113395fca678 (patch) | |
| tree | 403a7e197d030845f9f7e2c6b0a24aae17ab5eb5 /examples/registervirtualcomponentforuninstall/packages/component/meta/package.xml | |
| parent | 47ae652577a1013736a04e3c9a105b9094fe1ed6 (diff) | |
Optimize ExctractArchiveOperation::fileFinished()
This code was spending a lot of time detaching and
copying the file list, due to exporting it via the
setValue() call on each file finished iteration. This
was causing the install process to slow down, and
also made the UI freeze, giving the impression that the
install process had stopped.
Add the file paths to a local list instead, and then
call setValue when file extraction is complete.
Profiling shows that the installer now spends 95% of its
time extracting files on the ExctractArchiveOperation,
thread and 5% on the main thread.
Fixes: QTBUG-51337
Change-Id: Ieb4c44c03cb28eb46928730ca023f7419d72e45b
Reviewed-by: Katja Marttila <katja.marttila@qt.io>
Reviewed-by: David Faure <david.faure@kdab.com>
Diffstat (limited to 'examples/registervirtualcomponentforuninstall/packages/component/meta/package.xml')
0 files changed, 0 insertions, 0 deletions