diff options
author | Tim Jenssen <tim.jenssen@nokia.com> | 2011-11-10 15:26:08 +0100 |
---|---|---|
committer | Tim Jenssen <tim.jenssen@nokia.com> | 2011-11-14 10:38:58 +0100 |
commit | 81d9a2bdafd76f3f2fffd0f20037ec99fbb3349b (patch) | |
tree | 9326da295e172f2f442f8a66c2658c9673c07caa /installerbuilder | |
parent | 0ac080d3dcdebae66a6a9742e628b7cc2bdacdb4 (diff) |
use relevantComponentForAutoDependOne everywhere
- even in the autodepend->dependency transform loop at the beginning of appendComponentsToInstall
Change-Id: I8423b5fe80d3f02a2eb257e7b3985684faea71cb
Reviewed-by: Karsten Heimrich <karsten.heimrich@nokia.com>
Diffstat (limited to 'installerbuilder')
-rw-r--r-- | installerbuilder/libinstaller/packagemanagercore_p.cpp | 19 |
1 files changed, 9 insertions, 10 deletions
diff --git a/installerbuilder/libinstaller/packagemanagercore_p.cpp b/installerbuilder/libinstaller/packagemanagercore_p.cpp index 756e59249..b47f5af50 100644 --- a/installerbuilder/libinstaller/packagemanagercore_p.cpp +++ b/installerbuilder/libinstaller/packagemanagercore_p.cpp @@ -322,9 +322,17 @@ bool PackageManagerCorePrivate::appendComponentsToInstall(const QList<Component* return true; } + QList<Component*> relevantComponentForAutoDependOn; + if (isUpdater()) + relevantComponentForAutoDependOn = m_updaterComponents + m_updaterComponentsDeps; + else { + foreach (QInstaller::Component *component, m_rootComponents) + relevantComponentForAutoDependOn += component->childComponents(true, AllMode); + } + //build a data structure to be able to use autodependency as normal dependency m_autoDependOnDependencies.clear(); - foreach (Component *component, m_core->availableComponents()) { + foreach (Component *component, relevantComponentForAutoDependOn) { foreach (const QString componentName, component->autoDependencies()) { Component *componentWithAutoDependOnInspector = m_core->componentByName(componentName); if (componentWithAutoDependOnInspector != 0) { @@ -359,15 +367,6 @@ bool PackageManagerCorePrivate::appendComponentsToInstall(const QList<Component* return false; } - QList<Component*> relevantComponentForAutoDependOn; - if (isUpdater()) - relevantComponentForAutoDependOn = m_updaterComponents + m_updaterComponentsDeps; - else { - foreach (QInstaller::Component *component, m_rootComponents) - relevantComponentForAutoDependOn += component->childComponents(true, AllMode); - } - - QList<Component*> foundAutoDependOnList; // All regular dependencies are resolved. Now we are looking for auto depend on components. foreach (Component *component, relevantComponentForAutoDependOn) { |