Warn whenever (auto)dependencies are not leaf nodes.

Whenever any source or destination node
of dependency link or any destination node
of autodependency link has
children, warn about it. Maintenance tool
isn't able to handle such cases properly.

Change-Id: Ifaf3fbb7903eb960ab8fd977c4f47b7906900115
Reviewed-by: Niels Weber <niels.weber@theqtcompany.com>

1 files changed, 24 insertions, 0 deletions

diff --git a/src/libs/installer/componentchecker.cpp b/src/libs/installer/componentchecker.cpp
index 6b3e0160d..64ce851a0 100644
--- a/src/libs/installer/componentchecker.cpp
+++ b/src/libs/installer/componentchecker.cpp
@@ -88,6 +88,30 @@ QStringList ComponentChecker::checkComponent(Component *component)
                     .arg(component->name());
             }
         }
+        if (component->childCount()) {
+            const QStringList autoDependencies = component->autoDependencies();
+            if (!autoDependencies.isEmpty()) {
+                checkResult << QString::fromLatin1("Component %1 auto depends on other components "
+                    "while having children components. This will not work properly.")
+                    .arg(component->name());
+            }
+
+            // TODO: search also for components which autodepend on "component"
+            // (something like core->autodependees(component))
+
+            if (!component->dependencies().isEmpty()) {
+                checkResult << QString::fromLatin1("Component %1 depends on other components "
+                    "while having children components. This will not work properly.")
+                    .arg(component->name());
+            }
+
+            PackageManagerCore *core = component->packageManagerCore();
+            if (!core->dependees(component).isEmpty()) {
+                checkResult << QString::fromLatin1("Other components depend on component %1 "
+                    "which has children components. This will not work properly.")
+                    .arg(component->name());
+            }
+        }
     }
     return checkResult;
 }