diff options
| author | Katja Marttila <katja.marttila@qt.io> | 2020-02-13 12:12:53 +0200 |
|---|---|---|
| committer | Katja Marttila <katja.marttila@qt.io> | 2020-02-13 11:24:30 +0000 |
| commit | 9810d42fe922b6c684fa4711152d57c3648c33c0 (patch) | |
| tree | 8c08d676ac3189bc9768eeb9bdbdbfc594847080 /src/libs/installer/packagemanagercore.cpp | |
| parent | 42537f07b74c202afb433dcd2ff24d9084a48f9b (diff) | |
Fix CLI installPackages
Installer decided incorrectly weather the package was already installed or not.
Check from components isInstalled() instead of model check state as the
model check state can be Checked if <Default> is true and the component
is not installed.
Change-Id: Id1469992a2d56d263f47a6a711dbb878129f545a
Reviewed-by: Iikka Eklund <iikka.eklund@qt.io>
Diffstat (limited to 'src/libs/installer/packagemanagercore.cpp')
| -rw-r--r-- | src/libs/installer/packagemanagercore.cpp | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/src/libs/installer/packagemanagercore.cpp b/src/libs/installer/packagemanagercore.cpp index 74943f913..68a28f2ac 100644 --- a/src/libs/installer/packagemanagercore.cpp +++ b/src/libs/installer/packagemanagercore.cpp @@ -2119,7 +2119,7 @@ void PackageManagerCore::installSelectedComponentsSilently(const QStringList& co if (component && !component->isCheckable()) qCDebug(QInstaller::lcInstallerInstallLog) << "Cannot install component "<< name <<". Component is not checkable meaning you have to select one of the subcomponents."; - } else if (model->data(idx, Qt::CheckStateRole) == Qt::Checked ) { + } else if (component->isInstalled()) { qCDebug(QInstaller::lcInstallerInstallLog) << "Component " << name <<" already installed"; } else { model->setData(idx, Qt::Checked, Qt::CheckStateRole); |