diff options
| author | Arttu Tarkiainen <arttu.tarkiainen@qt.io> | 2019-07-24 16:45:39 +0300 |
|---|---|---|
| committer | Arttu Tarkiainen <arttu.tarkiainen@qt.io> | 2019-08-30 07:22:30 +0000 |
| commit | c410e4250266a04e7897ecd0c98c49f040f67205 (patch) | |
| tree | 81a3ebf3ec4cab211d03fd107a33110c318b88bf /src/libs/installer/packagemanagercore.h | |
| parent | 8f7af86198935849c74c71add7c9ca081347fb85 (diff) | |
Refactor setting and checking of file permissions
Create methods to explicitly set default file permissions on Unix
platforms, use these on installer created files and installation
target directory. Add unit test for introduced functions.
Remove method introduced in 46aecc23b2983c807ff2232ae9cb9651b4d2fdc2
as the same effect is achieved more efficiently by ensuring target
directory will be written with explicit permissions on initial
installation. Unlike the removed method, this will also not break if
an installed component contains owner non-writable directories.
Further simplify PackageManagerCore::directoryWritable() introduced
in 89f772f819178ee2502768c3d259d22ecb910fbe. Remove orphan unit
test for removed PackageManagerCore::subdirectoriesWritable().
This does not change permissions of files and directories extracted
for installed components.
Task-number: QTIFW-1412
Change-Id: I59698c78aceef874b1f79482bff5a618b9a1b536
Reviewed-by: Katja Marttila <katja.marttila@qt.io>
Diffstat (limited to 'src/libs/installer/packagemanagercore.h')
| -rw-r--r-- | src/libs/installer/packagemanagercore.h | 1 |
1 files changed, 0 insertions, 1 deletions
diff --git a/src/libs/installer/packagemanagercore.h b/src/libs/installer/packagemanagercore.h index f4240fde0..fd74a6cf7 100644 --- a/src/libs/installer/packagemanagercore.h +++ b/src/libs/installer/packagemanagercore.h @@ -122,7 +122,6 @@ public: static Component *componentByName(const QString &name, const QList<Component *> &components); bool directoryWritable(const QString &path) const; - bool subdirectoriesWritable(const QString &path) const; bool fetchLocalPackagesTree(); LocalPackagesHash localInstalledPackages(); |