diff options
| author | kh1 <karsten.heimrich@digia.com> | 2013-02-28 17:30:06 +0100 |
|---|---|---|
| committer | Karsten Heimrich <karsten.heimrich@digia.com> | 2013-03-18 11:39:18 +0100 |
| commit | 0249980607986b1b786886f61dc7d68dfb5b2420 (patch) | |
| tree | 6701b011384e5dcfdaa14932836b90fda5d15489 /src/libs/installer/qinstallerglobal.h | |
| parent | 7796a25de086de6276d5128d50469ab260528eeb (diff) | |
Use Q_GLOBAL_STATIC{_WITH_ARGS} following Qt coding conventions.
Move the regexp into its own compilation unit, so we get it only
once and use a accessor to fetch the value. I guess we should do
the same with the constants file, as all strings get compiled in
the file including it. At least Ossi wasn't satisfied currently.
Change-Id: Ic495a82f4b3cfe7810523b12cd3ef255eb15f149
Reviewed-by: Tim Jenssen <tim.jenssen@digia.com>
Reviewed-by: Karsten Heimrich <karsten.heimrich@digia.com>
Diffstat (limited to 'src/libs/installer/qinstallerglobal.h')
| -rw-r--r-- | src/libs/installer/qinstallerglobal.h | 2 |
1 files changed, 0 insertions, 2 deletions
diff --git a/src/libs/installer/qinstallerglobal.h b/src/libs/installer/qinstallerglobal.h index 81635830b..7f0fbbbc0 100644 --- a/src/libs/installer/qinstallerglobal.h +++ b/src/libs/installer/qinstallerglobal.h @@ -57,8 +57,6 @@ QT_END_NAMESPACE namespace QInstaller { -static QRegExp scCommaRegExp(QLatin1String("\\b(,|, )\\b")); - enum INSTALLER_EXPORT JobError { InvalidUrl = 0x24B04, |