diff options
author | Arttu Tarkiainen <arttu.tarkiainen@qt.io> | 2021-04-14 17:56:42 +0300 |
---|---|---|
committer | Arttu Tarkiainen <arttu.tarkiainen@qt.io> | 2021-05-04 06:09:31 +0000 |
commit | 14b12d2730bbde50dac8c81d4aef45ef78c48391 (patch) | |
tree | f6337e15e49651a87d48cfa834625c158dcf2c6c /src/libs/installer | |
parent | d54c162f1f4dff54be930ce2f7370dd540a1e1bf (diff) |
CLI: Print warning when creating over 4GB installers on Windows
Task-number: QTIFW-2199
Change-Id: I56f3663ae605b2c568925702e06c4438e11830ac
(cherry picked from commit 35f79da9cb99c7c0456f002829dc0fdfe55b4f8d)
Reviewed-by: Katja Marttila <katja.marttila@qt.io>
Diffstat (limited to 'src/libs/installer')
-rw-r--r-- | src/libs/installer/packagemanagercore.cpp | 10 |
1 files changed, 9 insertions, 1 deletions
diff --git a/src/libs/installer/packagemanagercore.cpp b/src/libs/installer/packagemanagercore.cpp index 6682bde7c..a18374f0c 100644 --- a/src/libs/installer/packagemanagercore.cpp +++ b/src/libs/installer/packagemanagercore.cpp @@ -70,7 +70,8 @@ #include "updateoperationfactory.h" #ifdef Q_OS_WIN -# include "qt_windows.h" +#include "qt_windows.h" +#include <limits> #endif #include <QStandardPaths> @@ -2718,6 +2719,13 @@ bool PackageManagerCore::checkAvailableSpace(QString &message) const message = tr("The volume you selected for installation seems to have sufficient " "space for installation, but there will be less than 100 MB available afterwards."); } +#ifdef Q_OS_WIN + if (isOfflineGenerator() && (required > UINT_MAX)) { + message = tr("The estimated installer size %1 would exceed the supported executable " + "size limit of %2. The application may not be able to run.") + .arg(humanReadableSize(required), humanReadableSize(UINT_MAX)); + } +#endif } message = QString::fromLatin1("%1 %2").arg(message, tr("Installation will use %1 of disk space.") .arg(humanReadableSize(requiredDiskSpace()))).simplified(); |