diff options
| author | Frerich Raabe <raabe@froglogic.com> | 2016-11-08 08:56:38 +0100 |
|---|---|---|
| committer | Katja Marttila <katja.marttila@qt.io> | 2016-11-28 05:01:07 +0000 |
| commit | 9bd807684eabd4623ee3cdfb02573d5cbe6ef4f7 (patch) | |
| tree | 98b8785db682af35b66fa2c5f81d6771d6581e66 /src/libs | |
| parent | b5b0a8d2657f874f09f157246a592a270ea78d87 (diff) | |
Fix crash at end of installer on Linux 64bit
The installer occasionally crashed at the very end of the installation,
apparently this is often triggered on Linux 64bit. It appears that this
is caused by two or more threads using qDebug() concurrently: some
operation still uses OperationTrace::trace() to print status output and
at the same time we try to call showFinishedPage(), which uses qDebug()
to print a not-so-useful message.
Getting qDebug() out of the operations seems to be tough, and defining
QT_NO_DEBUG_OUTPUT at build time to disable *all* qDebug() output feels
like overkill, so let's fix this crash by just not printing a message in
showFinishedPage().
Task-number: QTIFW-905
Change-Id: I4702eb511577148ae6cc0d32f1580d842e58e0b2
Reviewed-by: Katja Marttila <katja.marttila@qt.io>
Diffstat (limited to 'src/libs')
| -rw-r--r-- | src/libs/installer/packagemanagergui.cpp | 1 |
1 files changed, 0 insertions, 1 deletions
diff --git a/src/libs/installer/packagemanagergui.cpp b/src/libs/installer/packagemanagergui.cpp index 789a38b40..60811c2eb 100644 --- a/src/libs/installer/packagemanagergui.cpp +++ b/src/libs/installer/packagemanagergui.cpp @@ -849,7 +849,6 @@ void PackageManagerGui::setModified(bool value) */ void PackageManagerGui::showFinishedPage() { - qDebug() << "SHOW FINISHED PAGE"; if (d->m_autoSwitchPage) next(); else |