summaryrefslogtreecommitdiffstats
path: root/src/libs
diff options
context:
space:
mode:
authorKatja Marttila <katja.marttila@qt.io>2022-02-22 12:59:30 +0200
committerKatja Marttila <katja.marttila@qt.io>2022-02-22 12:59:55 +0200
commitce4e061c5f8dd4d316497f4fd5fac6561352bf49 (patch)
tree42a1d0d31b1d9b8c52a14861e258757fffac39fd /src/libs
parent07e48ef852a97fe55cb9c22bcb1a73df5131ce0b (diff)
parent99b2be3a9403b90678e13c1726eb360a7e43a1d4 (diff)
Merge remote-tracking branch 'origin/4.3' into master
Diffstat (limited to 'src/libs')
-rw-r--r--src/libs/installer/packagemanagercore.cpp2
-rw-r--r--src/libs/kdtools/updateoperation.cpp13
2 files changed, 7 insertions, 8 deletions
diff --git a/src/libs/installer/packagemanagercore.cpp b/src/libs/installer/packagemanagercore.cpp
index 5e98ea1de..d2c732ddb 100644
--- a/src/libs/installer/packagemanagercore.cpp
+++ b/src/libs/installer/packagemanagercore.cpp
@@ -2702,6 +2702,8 @@ PackageManagerCore::Status PackageManagerCore::installSelectedComponentsSilently
QString errorMessage;
if (checkComponentsForInstallation(components, errorMessage)) {
+ if (!errorMessage.isEmpty())
+ qCDebug(QInstaller::lcInstallerInstallLog).noquote().nospace() << errorMessage;
if (d->calculateComponentsAndRun())
qCDebug(QInstaller::lcInstallerInstallLog) << "Components installed successfully";
} else {
diff --git a/src/libs/kdtools/updateoperation.cpp b/src/libs/kdtools/updateoperation.cpp
index c3961663a..998d33094 100644
--- a/src/libs/kdtools/updateoperation.cpp
+++ b/src/libs/kdtools/updateoperation.cpp
@@ -549,21 +549,18 @@ bool UpdateOperation::fromXml(const QDomDocument &doc)
if (!e.isNull() && e.tagName() == QLatin1String("argument")) {
// Sniff the Execute -operations file path separator. The operation might be
// strict with the used path separator
+ bool useCleanPath = true;
if (name() == QLatin1String("Execute")) {
if (e.text().startsWith(relocatable) && e.text().size() > relocatable.size()) {
const QChar separator = e.text().at(relocatable.size());
if (separator == QLatin1Char('\\')) {
- args << QInstaller::replacePath(e.text(), relocatable,
- QDir::toNativeSeparators(target), false);
+ target = QDir::toNativeSeparators(target);
+ useCleanPath = false;
}
- } else {
- args << QInstaller::replacePath(e.text(), relocatable,
- target);
}
- } else {
- args << QInstaller::replacePath(e.text(), relocatable,
- target);
}
+ args << QInstaller::replacePath(e.text(), relocatable,
+ target, useCleanPath);
}
}
setArguments(args);