Exit early when trying to install already installed component

Task-number: QTIFW-1845
Change-Id: Iceea374ae4e027653c9e353fa2a4902e5fed790a
Reviewed-by: Arttu Tarkiainen <arttu.tarkiainen@qt.io>

1 files changed, 11 insertions, 1 deletions

diff --git a/src/libs/installer/packagemanagercore.cpp b/src/libs/installer/packagemanagercore.cpp
index e6b6de62b..183baf558 100644
--- a/src/libs/installer/packagemanagercore.cpp
+++ b/src/libs/installer/packagemanagercore.cpp
@@ -2398,11 +2398,21 @@ bool PackageManagerCore::removeInstallationSilently()
 */
 bool PackageManagerCore::installSelectedComponentsSilently(const QStringList& components)
 {
-    // Check if there are processes running in the install if maintenancetool is in used.
     if (!isInstaller()) {
+        // Check if there are processes running in the install if maintenancetool is used.
         if (d->runningProcessesFound())
             throw Error(tr("Running processes found."));
         setPackageManager();
+
+        //Check that packages are not already installed
+        const LocalPackagesHash installedPackages = this->localInstalledPackages();
+        QStringList helperStrList;
+        helperStrList << components << installedPackages.keys();
+        helperStrList.removeDuplicates();
+        if (helperStrList.count() == installedPackages.count()) {
+            qCDebug(QInstaller::lcInstallerInstallLog) << "Components already installed.";
+            return true;
+        }
     }
 
     ComponentModel *model = defaultComponentModel();