diff options
author | Jarek Kobus <jaroslaw.kobus@theqtcompany.com> | 2015-06-04 12:51:57 +0200 |
---|---|---|
committer | Jarek Kobus <jaroslaw.kobus@theqtcompany.com> | 2015-06-04 12:00:23 +0000 |
commit | 014bee19ae7939e0468f61c5b5ce18684df7df5b (patch) | |
tree | a90d5ab48200e4a2f78023919a9e92fc683c3984 /src | |
parent | 8482b4da46505c725d93a1e0478ded99bcbde4d2 (diff) |
Small optimization
Change-Id: Ia412f036e8285375e2fc2bd3a1eb7e18edd3dbea
Reviewed-by: Karsten Heimrich <karsten.heimrich@theqtcompany.com>
Diffstat (limited to 'src')
-rw-r--r-- | src/libs/installer/packagemanagercore_p.cpp | 11 |
1 files changed, 3 insertions, 8 deletions
diff --git a/src/libs/installer/packagemanagercore_p.cpp b/src/libs/installer/packagemanagercore_p.cpp index 46a38ab8a..9103526ae 100644 --- a/src/libs/installer/packagemanagercore_p.cpp +++ b/src/libs/installer/packagemanagercore_p.cpp @@ -2278,20 +2278,15 @@ OperationList PackageManagerCorePrivate::sortOperationsBasedOnComponentDependenc const QString componentName = operation->value(QLatin1String("component")).toString(); if (componentName.isEmpty()) sortedOperations.append(operation); - else { - OperationList componentOperationList = componentOperationHash.value(componentName); - componentOperationList.append(operation); - componentOperationHash.insert(operation->value(QLatin1String("component")).toString(), - componentOperationList); - } + else + componentOperationHash[componentName].append(operation); } - const QString empty; const QRegExp dash(QLatin1String("-.*")); Graph<QString> componentGraph; // create the complete component graph foreach (const Component* node, m_core->components(PackageManagerCore::ComponentType::All)) { componentGraph.addNode(node->name()); - componentGraph.addEdges(node->name(), node->dependencies().replaceInStrings(dash, empty)); + componentGraph.addEdges(node->name(), node->dependencies().replaceInStrings(dash, QString())); } const QStringList resolvedComponents = componentGraph.sort(); |