diff options
author | Frerich Raabe <raabe@froglogic.com> | 2015-11-05 17:03:01 +0100 |
---|---|---|
committer | Karsten Heimrich <karsten.heimrich@theqtcompany.com> | 2015-12-08 13:06:39 +0000 |
commit | 1963986ba756faca9a33d727563be1a5962191a8 (patch) | |
tree | e929783b84c28ba564e5a5f2aa191801d7cb9b71 /tests | |
parent | ac89d6b1e6fd50689cd047a8a92a0841367ff844 (diff) |
Fix violated assertion in error handling of binarycreator
The errorMessageFrom7zResult() function asserts (via a qFatal) that the
given status code is indeed an error, i.e. not S_OK. However, the
condition 'res != S_OK || !tempFile.exists()' permitted that the
function is called with S_OK (in case !tempFile.exists() is true),
violating an assertion.
This patch adjusts the error handling such that the details of the error
returned by errorMessageFrom7zResult() are only included in the
exception message if the status code is not S_OK.
Change-Id: I15d686cd35c918093ec90c56a7bcc3f0e6638cfb
Reviewed-by: Karsten Heimrich <karsten.heimrich@theqtcompany.com>
Diffstat (limited to 'tests')
0 files changed, 0 insertions, 0 deletions