9 files changed, 10 insertions, 10 deletions
diff --git a/src/libs/installer/component.cpp b/src/libs/installer/component.cpp
index 3019831a1..061c4e110 100644
--- a/src/libs/installer/component.cpp
+++ b/src/libs/installer/component.cpp
@@ -1346,7 +1346,7 @@ bool Component::isDefault() const
     return d->m_vars.value(scDefault).compare(scTrue, Qt::CaseInsensitive) == 0;
 }
 
-bool Component::isInstalled(const QString version) const
+bool Component::isInstalled(const QString &version) const
 {
     if (version.isEmpty()) {
         return scInstalled == d->m_vars.value(scCurrentState);
diff --git a/src/libs/installer/component.h b/src/libs/installer/component.h
index 3cb259bd1..fd12a53f8 100644
--- a/src/libs/installer/component.h
+++ b/src/libs/installer/component.h
@@ -175,7 +175,7 @@ public:
     Q_INVOKABLE bool isAutoDependOn(const QSet<QString> &componentsToInstall) const;
 
     Q_INVOKABLE void setInstalled();
-    Q_INVOKABLE bool isInstalled(const QString version = QString()) const;
+    Q_INVOKABLE bool isInstalled(const QString &version = QString()) const;
     Q_INVOKABLE bool installationRequested() const;
     bool isSelectedForInstallation() const;
 
diff --git a/src/libs/installer/createshortcutoperation.cpp b/src/libs/installer/createshortcutoperation.cpp
index 93044196d..57f901c2f 100644
--- a/src/libs/installer/createshortcutoperation.cpp
+++ b/src/libs/installer/createshortcutoperation.cpp
@@ -87,7 +87,7 @@ static QString parentDirectory(const QString &current)
     return current.mid(0, current.lastIndexOf(QLatin1Char('/')));
 }
 
-static QString takeArgument(const QString argument, QStringList *arguments)
+static QString takeArgument(const QString &argument, QStringList *arguments)
 {
     // if the arguments contain an option in the form "argument=...", find it and consume it
     QStringList::iterator it = std::find_if(arguments->begin(), arguments->end(), StartsWith(argument));
@@ -99,7 +99,7 @@ static QString takeArgument(const QString argument, QStringList *arguments)
     return value;
 }
 
-static bool createLink(const QString &fileName, const QString &linkName, QString workingDir,
+static bool createLink(const QString &fileName, const QString &linkName, QString &workingDir,
     const QString &arguments = QString(), const QString &iconPath = QString(),
     const QString &iconId = QString(), const QString &description = QString())
 {
diff --git a/src/libs/installer/installiconsoperation.cpp b/src/libs/installer/installiconsoperation.cpp
index 6b4852a6e..eea83a462 100644
--- a/src/libs/installer/installiconsoperation.cpp
+++ b/src/libs/installer/installiconsoperation.cpp
@@ -129,7 +129,7 @@ bool InstallIconsOperation::performOperation()
         if (status == PackageManagerCore::Canceled || status == PackageManagerCore::Failure)
             return true;
 
-        const QString source = it.next();
+        const QString &source = it.next();
         QString target = targetDir.absoluteFilePath(sourceDir.relativeFilePath(source));
 
         emit outputTextChanged(target);
diff --git a/src/libs/installer/metadatajob.cpp b/src/libs/installer/metadatajob.cpp
index a369461ca..a15dd8848 100644
--- a/src/libs/installer/metadatajob.cpp
+++ b/src/libs/installer/metadatajob.cpp
@@ -225,7 +225,7 @@ void MetadataJob::doStart()
     }
 }
 
-void MetadataJob::startXMLTask(const QList<FileTaskItem> items)
+void MetadataJob::startXMLTask(const QList<FileTaskItem> &items)
 {
     DownloadFileTask *const xmlTask = new DownloadFileTask(items);
     xmlTask->setProxyFactory(m_core->proxyFactory());
diff --git a/src/libs/installer/metadatajob.h b/src/libs/installer/metadatajob.h
index f8f935529..eb0e91a4f 100644
--- a/src/libs/installer/metadatajob.h
+++ b/src/libs/installer/metadatajob.h
@@ -93,7 +93,7 @@ private slots:
     void progressChanged(int progress);
     void setProgressTotalAmount(int maximum);
     void unzipRepositoryTaskFinished();
-    void startXMLTask(const QList<FileTaskItem> items);
+    void startXMLTask(const QList<FileTaskItem> &items);
 
 private:
     bool fetchMetaDataPackages();
diff --git a/src/libs/installer/repositorycategory.cpp b/src/libs/installer/repositorycategory.cpp
index 4e8d45abd..89f88c1d7 100644
--- a/src/libs/installer/repositorycategory.cpp
+++ b/src/libs/installer/repositorycategory.cpp
@@ -128,7 +128,7 @@ void RepositoryCategory::setRepositories(const QSet<Repository> repositories, co
 /*!
     Inserts \a repository to the category.
 */
-void RepositoryCategory::addRepository(const Repository repository)
+void RepositoryCategory::addRepository(const Repository &repository)
 {
     m_data.insertMulti(scRepositories, QVariant().fromValue(repository));
 }
diff --git a/src/libs/installer/repositorycategory.h b/src/libs/installer/repositorycategory.h
index faa8d252b..51dc3ddfb 100644
--- a/src/libs/installer/repositorycategory.h
+++ b/src/libs/installer/repositorycategory.h
@@ -55,7 +55,7 @@ public:
 
     QSet<Repository> repositories() const;
     void setRepositories(const QSet<Repository> repositories, const bool replace = false);
-    void addRepository(const Repository repository);
+    void addRepository(const Repository &repository);
 
     bool isEnabled() const;
     void setEnabled(bool enabled);
diff --git a/src/libs/kdtools/sysinfo.cpp b/src/libs/kdtools/sysinfo.cpp
index 871596c7c..df9a374f2 100644
--- a/src/libs/kdtools/sysinfo.cpp
+++ b/src/libs/kdtools/sysinfo.cpp
@@ -144,7 +144,7 @@ bool VolumeInfo::operator==(const VolumeInfo &other) const
     return m_volumeDescriptor == other.m_volumeDescriptor;
 }
 
-QDebug operator<<(QDebug dbg, VolumeInfo volume)
+QDebug operator<<(QDebug dbg, const VolumeInfo &volume)
 {
     return dbg << "KDUpdater::Volume(" << volume.mountPath() << ")";
 }